-
Notifications
You must be signed in to change notification settings - Fork 456
chore(aioredis): mark deprecation #14356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 274 ± 4 ms. The average import time from base is: 274 ± 5 ms. The import time difference between this PR and base is: 0.2 ± 0.2 ms. The difference is not statistically significant (z = 1.15). Import time breakdownThe following import paths have shrunk:
|
Performance SLOsCandidate: emmett.butler/aioredis-deprecate (92b1486) 🔵 No Baseline Data (24 suites)🔵 coreapiscenario - 12/12 (2 unstable)🔵 No baseline data available for this suite
|
@tabgok I'd like to know if this change is acceptable from the IDM perspective |
The aioredis integration has been deprecated since this release note. This change adds a deprecation warning to its
patch()
function.Checklist
Reviewer Checklist