-
Notifications
You must be signed in to change notification settings - Fork 456
fix(iast): prevent SQLAlchemy __repr__ exceptions during modulo formatting #14350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 273 ± 6 ms. The average import time from base is: 280 ± 10 ms. The import time difference between this PR and base is: -9.9 ± 0.4 ms. Import time breakdownThe following import paths have shrunk:
|
Performance SLOsCandidate: avara1986/APPSEC-58629_sqli_error (0b515ca) 🔵 No Baseline Data (24 suites)🔵 coreapiscenario - 12/12 (2 unstable)🔵 No baseline data available for this suite
|
do_modulo() : Replace multi-stage format attempts with a single normalized call. Replace PyObject_CallMethodObjArgs("__mod__") with PyNumber_Remainder. Remove Py_INCREF on borrowed tuple/mapping; manage ownership only for PyTuple_Pack(...). api_modulo_aspect() : get_result simplified to call do_modulo(...) only. Removed repr-probing and pybind fallback path. If you’d like, I can proceed to streamline the taint branch in the same file (build formatted parameters via PyTuple_New/PyTuple_SET_ITEM, avoid pre-formatting template if no ranges, and share conversions) to capture additional gains when taint is involved. feat/fix/docs/refactor/ci(xxx): commit title here
%
-formatting inside the IAST modulo aspect.Why it’s safe
APMS-16229 & APPSEC-58629
Checklist
Reviewer Checklist