-
Notifications
You must be signed in to change notification settings - Fork 455
chore(ci_visibility): replace weak dicts with regular dicts #14348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci_visibility): replace weak dicts with regular dicts #14348
Conversation
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 267 ± 2 ms. The average import time from base is: 269 ± 3 ms. The import time difference between this PR and base is: -2.2 ± 0.1 ms. Import time breakdownThe following import paths have shrunk:
|
Performance SLOsCandidate: vitor-de-araujo/SDTEST-2481/no-weak-dicts (27e4483) 🔵 No Baseline Data (24 suites)🔵 coreapiscenario - 12/12 (2 unstable)🔵 No baseline data available for this suite
|
After changes from PRs #14328 and #14344, the dictionaries of test exceptions and reports are cleaned up manually, so they don't have to be
WeakKeyDictionary
anymore. The dictionaries being weak not only don't help, they also cause flakiness in one of the tests (test_pytest_clears_excinfo_dict_after_use
) because the number of elements in the dicts is not reliable.Checklist
Reviewer Checklist