-
Notifications
You must be signed in to change notification settings - Fork 456
chore(redis): use the core API in redis instrumentations #14341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 270 ± 4 ms. The average import time from base is: 269 ± 2 ms. The import time difference between this PR and base is: 0.8 ± 0.2 ms. Import time breakdownThe following import paths have appeared:
|
Performance SLOsCandidate: emmett.butler/aredis-core (7b67a45) 🔵 No Baseline Data (24 suites)🔵 coreapiscenario - 12/12 (2 unstable)🔵 No baseline data available for this suite
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
handful of small nits, nothing too blocking, just things I have encountered/done with Django rewriting
Co-authored-by: Brett Langdon <[email protected]>
Co-authored-by: Brett Langdon <[email protected]>
Co-authored-by: Brett Langdon <[email protected]>
Co-authored-by: Brett Langdon <[email protected]>
This change updates the widely-used redis utility functions to ue the core API, facilitating clearer separation of concerns between instrumentation and tracing. To this end, it also moves utility functions to the appropriate subpackage:
_trace
for those related to tracing andcontrib.internal
for those related to instrumentation.Checklist
Reviewer Checklist