Skip to content

[Datadog] Fix Static Code Analysis violation #13534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

whitemerch
Copy link

This pull request was automatically created by Datadog to fix this vulnerability.

It introduces a remediation for the AST vulnerability detected by rule python-security/avoid-random.

This change is intended to address the issue identified. Please review the suggested update before merging.

Co-authored-by: datadog-datadog-staging-us1-all[bot] <92110531+datadog-datadog-staging-us1-all[bot]@users.noreply.github.com>
Copy link
Contributor

CODEOWNERS have been resolved as:

ddtrace/vendor/dogstatsd/base.py                                        @DataDog/apm-core-python

Copy link
Contributor

Bootstrap import analysis

Comparison of import times between this PR and base.

Summary

The average import time from this PR is: 239 ± 4 ms.

The average import time from base is: 241 ± 4 ms.

The import time difference between this PR and base is: -1.9 ± 0.2 ms.

Import time breakdown

The following import paths have shrunk:

ddtrace.auto 2.001 ms (0.84%)
ddtrace.bootstrap.sitecustomize 1.323 ms (0.55%)
ddtrace.bootstrap.preload 1.323 ms (0.55%)
ddtrace.internal.remoteconfig.client 0.653 ms (0.27%)
ddtrace 0.678 ms (0.28%)
ddtrace.internal._unpatched 0.022 ms (0.01%)

@pr-commenter
Copy link

pr-commenter bot commented May 29, 2025

Benchmarks

Benchmark execution time: 2025-05-29 16:56:58

Comparing candidate commit 76f6908 in PR branch dd-static-analysis-cZmC2ln with baseline commit fc6b273 in branch main.

Found 2 performance improvements and 0 performance regressions! Performance is the same for 508 metrics, 6 unstable metrics.

scenario:iastdjangostartup-appsec

  • 🟩 execution_time [-1.096s; -0.997s] or [-55.370%; -50.377%]

scenario:iastdjangostartup-tracer

  • 🟩 execution_time [-893.637ms; -803.012ms] or [-50.703%; -45.561%]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant