-
Couldn't load subscription status.
- Fork 314
Fix logging when uninstrumenting cannot happen #9851
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
if we have a thread in a loop that cannot exit the instrumented method for a while, instrumentation cannot be done. But probe is removed from metadata and cannot be resolved. We were logging this status which is in fact not helpful and generate noise. If probe cannot be resolved we just ignore the instrumentation
Debugger benchmarksParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 5 unstable metrics. See unchanged results
Request duration reports for reportsgantt
title reports - request duration [CI 0.99] : candidate=None, baseline=None
dateFormat X
axisFormat %s
section baseline
noprobe (322.364 µs) : 292, 352
. : milestone, 322,
basic (297.745 µs) : 291, 305
. : milestone, 298,
loop (8.959 ms) : 8956, 8963
. : milestone, 8959,
section candidate
noprobe (322.347 µs) : 289, 355
. : milestone, 322,
basic (293.546 µs) : 287, 300
. : milestone, 294,
loop (8.958 ms) : 8954, 8962
. : milestone, 8958,
|
|
🎯 Code Coverage 🔗 Commit SHA: 79a9271 | Docs | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 54 metrics, 11 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.55.0-SNAPSHOT~79a9271692, baseline=1.55.0-SNAPSHOT~f296927f57
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.036 s) : 0, 1036401
Total [baseline] (10.852 s) : 0, 10851943
Agent [candidate] (1.033 s) : 0, 1033462
Total [candidate] (10.778 s) : 0, 10778417
section appsec
Agent [baseline] (1.204 s) : 0, 1203537
Total [baseline] (10.975 s) : 0, 10974571
Agent [candidate] (1.203 s) : 0, 1202749
Total [candidate] (10.938 s) : 0, 10937751
section iast
Agent [baseline] (1.161 s) : 0, 1161173
Total [baseline] (11.131 s) : 0, 11130558
Agent [candidate] (1.16 s) : 0, 1160107
Total [candidate] (11.078 s) : 0, 11077678
section profiling
Agent [baseline] (1.176 s) : 0, 1175931
Total [baseline] (10.923 s) : 0, 10922646
Agent [candidate] (1.173 s) : 0, 1173421
Total [candidate] (10.902 s) : 0, 10902179
gantt
title petclinic - break down per module: candidate=1.55.0-SNAPSHOT~79a9271692, baseline=1.55.0-SNAPSHOT~f296927f57
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.47 ms) : 0, 1470
crashtracking [candidate] (1.479 ms) : 0, 1479
BytebuddyAgent [baseline] (706.681 ms) : 0, 706681
BytebuddyAgent [candidate] (703.59 ms) : 0, 703590
GlobalTracer [baseline] (246.486 ms) : 0, 246486
GlobalTracer [candidate] (246.27 ms) : 0, 246270
AppSec [baseline] (32.463 ms) : 0, 32463
AppSec [candidate] (32.714 ms) : 0, 32714
Debugger [baseline] (6.403 ms) : 0, 6403
Debugger [candidate] (6.426 ms) : 0, 6426
Remote Config [baseline] (696.308 µs) : 0, 696
Remote Config [candidate] (683.673 µs) : 0, 684
Telemetry [baseline] (13.741 ms) : 0, 13741
Telemetry [candidate] (13.015 ms) : 0, 13015
Flare Poller [baseline] (7.138 ms) : 0, 7138
Flare Poller [candidate] (7.999 ms) : 0, 7999
section appsec
crashtracking [baseline] (1.486 ms) : 0, 1486
crashtracking [candidate] (1.485 ms) : 0, 1485
BytebuddyAgent [baseline] (725.628 ms) : 0, 725628
BytebuddyAgent [candidate] (726.626 ms) : 0, 726626
GlobalTracer [baseline] (236.361 ms) : 0, 236361
GlobalTracer [candidate] (235.86 ms) : 0, 235860
AppSec [baseline] (175.063 ms) : 0, 175063
AppSec [candidate] (173.979 ms) : 0, 173979
Debugger [baseline] (5.921 ms) : 0, 5921
Debugger [candidate] (5.849 ms) : 0, 5849
Remote Config [baseline] (626.122 µs) : 0, 626
Remote Config [candidate] (623.907 µs) : 0, 624
Telemetry [baseline] (8.409 ms) : 0, 8409
Telemetry [candidate] (8.416 ms) : 0, 8416
Flare Poller [baseline] (3.866 ms) : 0, 3866
Flare Poller [candidate] (3.847 ms) : 0, 3847
IAST [baseline] (25.055 ms) : 0, 25055
IAST [candidate] (24.968 ms) : 0, 24968
section iast
crashtracking [baseline] (1.477 ms) : 0, 1477
crashtracking [candidate] (1.475 ms) : 0, 1475
BytebuddyAgent [baseline] (823.455 ms) : 0, 823455
BytebuddyAgent [candidate] (822.989 ms) : 0, 822989
GlobalTracer [baseline] (234.026 ms) : 0, 234026
GlobalTracer [candidate] (233.887 ms) : 0, 233887
AppSec [baseline] (30.751 ms) : 0, 30751
AppSec [candidate] (28.783 ms) : 0, 28783
Debugger [baseline] (6.067 ms) : 0, 6067
Debugger [candidate] (6.063 ms) : 0, 6063
Remote Config [baseline] (593.311 µs) : 0, 593
Remote Config [candidate] (598.036 µs) : 0, 598
Telemetry [baseline] (8.434 ms) : 0, 8434
Telemetry [candidate] (8.391 ms) : 0, 8391
Flare Poller [baseline] (4.137 ms) : 0, 4137
Flare Poller [candidate] (4.134 ms) : 0, 4134
IAST [baseline] (30.913 ms) : 0, 30913
IAST [candidate] (32.498 ms) : 0, 32498
section profiling
ProfilingAgent [baseline] (109.999 ms) : 0, 109999
ProfilingAgent [candidate] (109.398 ms) : 0, 109398
crashtracking [baseline] (1.462 ms) : 0, 1462
crashtracking [candidate] (1.471 ms) : 0, 1471
BytebuddyAgent [baseline] (728.009 ms) : 0, 728009
BytebuddyAgent [candidate] (727.183 ms) : 0, 727183
GlobalTracer [baseline] (220.946 ms) : 0, 220946
GlobalTracer [candidate] (220.205 ms) : 0, 220205
AppSec [baseline] (32.447 ms) : 0, 32447
AppSec [candidate] (32.326 ms) : 0, 32326
Debugger [baseline] (11.435 ms) : 0, 11435
Debugger [candidate] (11.326 ms) : 0, 11326
Remote Config [baseline] (1.456 ms) : 0, 1456
Remote Config [candidate] (700.051 µs) : 0, 700
Telemetry [baseline] (10.632 ms) : 0, 10632
Telemetry [candidate] (11.328 ms) : 0, 11328
Flare Poller [baseline] (4.059 ms) : 0, 4059
Flare Poller [candidate] (4.117 ms) : 0, 4117
Profiling [baseline] (110.638 ms) : 0, 110638
Profiling [candidate] (110.029 ms) : 0, 110029
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.55.0-SNAPSHOT~79a9271692, baseline=1.55.0-SNAPSHOT~f296927f57
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.044 s) : 0, 1043589
Total [baseline] (8.68 s) : 0, 8679850
Agent [candidate] (1.03 s) : 0, 1029905
Total [candidate] (8.653 s) : 0, 8653333
section iast
Agent [baseline] (1.161 s) : 0, 1161160
Total [baseline] (9.346 s) : 0, 9345826
Agent [candidate] (1.168 s) : 0, 1168175
Total [candidate] (9.356 s) : 0, 9355663
gantt
title insecure-bank - break down per module: candidate=1.55.0-SNAPSHOT~79a9271692, baseline=1.55.0-SNAPSHOT~f296927f57
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.499 ms) : 0, 1499
crashtracking [candidate] (1.46 ms) : 0, 1460
BytebuddyAgent [baseline] (713.085 ms) : 0, 713085
BytebuddyAgent [candidate] (702.412 ms) : 0, 702412
GlobalTracer [baseline] (246.62 ms) : 0, 246620
GlobalTracer [candidate] (244.941 ms) : 0, 244941
AppSec [baseline] (32.686 ms) : 0, 32686
AppSec [candidate] (32.11 ms) : 0, 32110
Debugger [baseline] (6.527 ms) : 0, 6527
Debugger [candidate] (6.372 ms) : 0, 6372
Remote Config [baseline] (691.873 µs) : 0, 692
Remote Config [candidate] (672.199 µs) : 0, 672
Telemetry [baseline] (15.28 ms) : 0, 15280
Telemetry [candidate] (13.549 ms) : 0, 13549
Flare Poller [baseline] (5.696 ms) : 0, 5696
Flare Poller [candidate] (7.197 ms) : 0, 7197
section iast
crashtracking [baseline] (1.469 ms) : 0, 1469
crashtracking [candidate] (1.483 ms) : 0, 1483
BytebuddyAgent [baseline] (823.741 ms) : 0, 823741
BytebuddyAgent [candidate] (829.689 ms) : 0, 829689
GlobalTracer [baseline] (234.723 ms) : 0, 234723
GlobalTracer [candidate] (234.921 ms) : 0, 234921
IAST [baseline] (30.857 ms) : 0, 30857
IAST [candidate] (30.794 ms) : 0, 30794
AppSec [baseline] (29.787 ms) : 0, 29787
AppSec [candidate] (30.659 ms) : 0, 30659
Debugger [baseline] (6.106 ms) : 0, 6106
Debugger [candidate] (6.091 ms) : 0, 6091
Remote Config [baseline] (607.399 µs) : 0, 607
Remote Config [candidate] (586.383 µs) : 0, 586
Telemetry [baseline] (8.427 ms) : 0, 8427
Telemetry [candidate] (8.401 ms) : 0, 8401
Flare Poller [baseline] (4.163 ms) : 0, 4163
Flare Poller [candidate] (4.119 ms) : 0, 4119
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 2 performance regressions! Performance is the same for 10 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~79a9271692, baseline=1.55.0-SNAPSHOT~f296927f57
dateFormat X
axisFormat %s
section baseline
no_agent (4.287 ms) : 4239, 4335
. : milestone, 4287,
iast (9.84 ms) : 9674, 10005
. : milestone, 9840,
iast_FULL (13.847 ms) : 13575, 14118
. : milestone, 13847,
iast_GLOBAL (11.165 ms) : 10965, 11365
. : milestone, 11165,
profiling (8.629 ms) : 8496, 8763
. : milestone, 8629,
tracing (8.02 ms) : 7900, 8140
. : milestone, 8020,
section candidate
no_agent (4.259 ms) : 4210, 4307
. : milestone, 4259,
iast (9.772 ms) : 9603, 9940
. : milestone, 9772,
iast_FULL (14.104 ms) : 13818, 14391
. : milestone, 14104,
iast_GLOBAL (11.331 ms) : 11125, 11537
. : milestone, 11331,
profiling (8.837 ms) : 8695, 8979
. : milestone, 8837,
tracing (7.934 ms) : 7821, 8048
. : milestone, 7934,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~79a9271692, baseline=1.55.0-SNAPSHOT~f296927f57
dateFormat X
axisFormat %s
section baseline
no_agent (36.321 ms) : 36032, 36611
. : milestone, 36321,
appsec (48.345 ms) : 47929, 48761
. : milestone, 48345,
code_origins (42.171 ms) : 41828, 42513
. : milestone, 42171,
iast (44.265 ms) : 43869, 44661
. : milestone, 44265,
profiling (47.177 ms) : 46721, 47633
. : milestone, 47177,
tracing (44.501 ms) : 44111, 44891
. : milestone, 44501,
section candidate
no_agent (38.036 ms) : 37728, 38345
. : milestone, 38036,
appsec (48.968 ms) : 48540, 49396
. : milestone, 48968,
code_origins (43.601 ms) : 43225, 43977
. : milestone, 43601,
iast (44.705 ms) : 44315, 45095
. : milestone, 44705,
profiling (47.975 ms) : 47561, 48389
. : milestone, 47975,
tracing (45.037 ms) : 44652, 45422
. : milestone, 45037,
DacapoParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 0 unstable metrics.
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~79a9271692, baseline=1.55.0-SNAPSHOT~f296927f57
dateFormat X
axisFormat %s
section baseline
no_agent (1.486 ms) : 1474, 1497
. : milestone, 1486,
appsec (3.705 ms) : 3487, 3923
. : milestone, 3705,
iast (2.224 ms) : 2161, 2288
. : milestone, 2224,
iast_GLOBAL (2.266 ms) : 2202, 2330
. : milestone, 2266,
profiling (2.087 ms) : 2034, 2139
. : milestone, 2087,
tracing (2.037 ms) : 1987, 2086
. : milestone, 2037,
section candidate
no_agent (1.487 ms) : 1475, 1498
. : milestone, 1487,
appsec (2.476 ms) : 2425, 2526
. : milestone, 2476,
iast (2.217 ms) : 2154, 2281
. : milestone, 2217,
iast_GLOBAL (2.264 ms) : 2200, 2328
. : milestone, 2264,
profiling (2.082 ms) : 2029, 2135
. : milestone, 2082,
tracing (2.045 ms) : 1995, 2095
. : milestone, 2045,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~79a9271692, baseline=1.55.0-SNAPSHOT~f296927f57
dateFormat X
axisFormat %s
section baseline
no_agent (15.057 s) : 15057000, 15057000
. : milestone, 15057000,
appsec (15.231 s) : 15231000, 15231000
. : milestone, 15231000,
iast (18.617 s) : 18617000, 18617000
. : milestone, 18617000,
iast_GLOBAL (17.827 s) : 17827000, 17827000
. : milestone, 17827000,
profiling (15.262 s) : 15262000, 15262000
. : milestone, 15262000,
tracing (15.328 s) : 15328000, 15328000
. : milestone, 15328000,
section candidate
no_agent (15.515 s) : 15515000, 15515000
. : milestone, 15515000,
appsec (14.962 s) : 14962000, 14962000
. : milestone, 14962000,
iast (18.96 s) : 18960000, 18960000
. : milestone, 18960000,
iast_GLOBAL (18.238 s) : 18238000, 18238000
. : milestone, 18238000,
profiling (15.777 s) : 15777000, 15777000
. : milestone, 15777000,
tracing (15.283 s) : 15283000, 15283000
. : milestone, 15283000,
|
What Does This Do
if we have a thread in a loop that cannot exit the instrumented method for a while, instrumentation cannot be done. But probe is removed from metadata and cannot be resolved. We were logging this status which is in fact not helpful and generate noise.
If probe cannot be resolved we just ignore the instrumentation
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: DEBUG-2394