Skip to content

Limit writer logs only when LLMObs is enabled #9781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 28, 2025
Merged

Limit writer logs only when LLMObs is enabled #9781

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b6b9dda
fix: limit writer logs only when LLMObs is enabled
daniel-mohedano Oct 16, 2025
3d0bf41
Merge branch 'master' into daniel.mohedano/llm-obs-writer-logs
daniel-mohedano Oct 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 18 additions & 16 deletions dd-trace-core/src/main/java/datadog/trace/common/writer/WriterFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,25 +181,27 @@ private static RemoteApi createDDIntakeRemoteApi(
TrackType trackType) {
featuresDiscovery.discoverIfOutdated();
boolean evpProxySupported = featuresDiscovery.supportsEvpProxy();
boolean useProxyApi = false;

if (TrackType.LLMOBS == trackType) {
useProxyApi = evpProxySupported && !config.isLlmObsAgentlessEnabled();
Copy link
Contributor

@ygree ygree Oct 21, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The !config.isLlmObsAgentlessEnabled() check can be done once for clarity.

if (!evpProxySupported && !config.isLlmObsAgentlessEnabled()) {
// Agentless is forced due to lack of evp proxy support
boolean agentRunning = null != featuresDiscovery.getTraceEndpoint();
if (agentRunning) {
log.info(
"LLM Observability configured to use agent proxy, but not compatible with agent version {}. Please upgrade to v7.55+.",
featuresDiscovery.getVersion());
} else {
log.info("LLM Observability configured to use agent proxy, but agent is not running.");
}
log.info("LLM Observability will use agentless data submission instead.");
}

boolean useLlmObsAgentless = config.isLlmObsAgentlessEnabled() || !evpProxySupported;
if (useLlmObsAgentless && !config.isLlmObsAgentlessEnabled()) {
boolean agentRunning = null != featuresDiscovery.getTraceEndpoint();
log.info(
"LLM Observability configured to use agent proxy, but is not compatible or agent is not running (agentRunning={}, compatible={})",
agentRunning,
evpProxySupported);
log.info(
"LLM Observability will use agentless data submission instead. Compatible agent versions are >=7.55.0 (found version={}",
featuresDiscovery.getVersion());
} else if (TrackType.CITESTCOV == trackType || TrackType.CITESTCYCLE == trackType) {
useProxyApi = evpProxySupported && !config.isCiVisibilityAgentlessEnabled();
}

boolean useProxyApi =
(TrackType.LLMOBS == trackType && !useLlmObsAgentless)
|| (evpProxySupported
&& (TrackType.CITESTCOV == trackType || TrackType.CITESTCYCLE == trackType)
&& !config.isCiVisibilityAgentlessEnabled());

if (useProxyApi) {
return DDEvpProxyApi.builder()
.httpClient(commObjects.agentHttpClient)
Expand Down
Loading