-
Notifications
You must be signed in to change notification settings - Fork 312
Set max JVM test version for log4j1 #9437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🎯 Code Coverage 🔗 Commit SHA: 9c53c2e | Docs | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 45 metrics, 14 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.53.0-SNAPSHOT~9c53c2ee5f, baseline=1.53.0-SNAPSHOT~d07fee98fb
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.054 s) : 0, 1053849
Total [baseline] (8.678 s) : 0, 8677840
Agent [candidate] (1.047 s) : 0, 1046745
Total [candidate] (8.625 s) : 0, 8625447
section iast
Agent [baseline] (1.179 s) : 0, 1178875
Total [baseline] (9.348 s) : 0, 9348477
Agent [candidate] (1.179 s) : 0, 1178961
Total [candidate] (9.374 s) : 0, 9373734
gantt
title insecure-bank - break down per module: candidate=1.53.0-SNAPSHOT~9c53c2ee5f, baseline=1.53.0-SNAPSHOT~d07fee98fb
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.46 ms) : 0, 1460
crashtracking [candidate] (1.447 ms) : 0, 1447
BytebuddyAgent [baseline] (738.145 ms) : 0, 738145
BytebuddyAgent [candidate] (731.305 ms) : 0, 731305
GlobalTracer [baseline] (244.276 ms) : 0, 244276
GlobalTracer [candidate] (242.194 ms) : 0, 242194
AppSec [baseline] (30.434 ms) : 0, 30434
AppSec [candidate] (29.909 ms) : 0, 29909
Debugger [baseline] (6.101 ms) : 0, 6101
Debugger [candidate] (6.105 ms) : 0, 6105
Remote Config [baseline] (674.781 µs) : 0, 675
Remote Config [candidate] (664.168 µs) : 0, 664
Telemetry [baseline] (11.67 ms) : 0, 11670
Telemetry [candidate] (14.215 ms) : 0, 14215
section iast
crashtracking [baseline] (1.45 ms) : 0, 1450
crashtracking [candidate] (1.452 ms) : 0, 1452
BytebuddyAgent [baseline] (851.387 ms) : 0, 851387
BytebuddyAgent [candidate] (850.852 ms) : 0, 850852
GlobalTracer [baseline] (232.651 ms) : 0, 232651
GlobalTracer [candidate] (233.014 ms) : 0, 233014
AppSec [baseline] (25.806 ms) : 0, 25806
AppSec [candidate] (26.723 ms) : 0, 26723
Debugger [baseline] (5.809 ms) : 0, 5809
Debugger [candidate] (6.623 ms) : 0, 6623
Remote Config [baseline] (606.689 µs) : 0, 607
Remote Config [candidate] (596.458 µs) : 0, 596
Telemetry [baseline] (8.295 ms) : 0, 8295
Telemetry [candidate] (8.319 ms) : 0, 8319
IAST [baseline] (31.982 ms) : 0, 31982
IAST [candidate] (30.342 ms) : 0, 30342
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.53.0-SNAPSHOT~9c53c2ee5f, baseline=1.53.0-SNAPSHOT~d07fee98fb
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.059 s) : 0, 1059345
Total [baseline] (10.698 s) : 0, 10698262
Agent [candidate] (1.048 s) : 0, 1047582
Total [candidate] (10.72 s) : 0, 10720338
section appsec
Agent [baseline] (1.228 s) : 0, 1228275
Total [baseline] (10.813 s) : 0, 10812801
Agent [candidate] (1.228 s) : 0, 1227555
Total [candidate] (10.819 s) : 0, 10819142
section iast
Agent [baseline] (1.181 s) : 0, 1180943
Total [baseline] (10.922 s) : 0, 10922339
Agent [candidate] (1.188 s) : 0, 1188226
Total [candidate] (10.925 s) : 0, 10924926
section profiling
Agent [baseline] (1.198 s) : 0, 1198152
Total [baseline] (10.916 s) : 0, 10915730
Agent [candidate] (1.197 s) : 0, 1197075
Total [candidate] (10.864 s) : 0, 10863842
gantt
title petclinic - break down per module: candidate=1.53.0-SNAPSHOT~9c53c2ee5f, baseline=1.53.0-SNAPSHOT~d07fee98fb
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.476 ms) : 0, 1476
crashtracking [candidate] (1.446 ms) : 0, 1446
BytebuddyAgent [baseline] (739.791 ms) : 0, 739791
BytebuddyAgent [candidate] (732.08 ms) : 0, 732080
GlobalTracer [baseline] (244.806 ms) : 0, 244806
GlobalTracer [candidate] (242.454 ms) : 0, 242454
AppSec [baseline] (30.552 ms) : 0, 30552
AppSec [candidate] (30.076 ms) : 0, 30076
Debugger [baseline] (6.087 ms) : 0, 6087
Debugger [candidate] (6.128 ms) : 0, 6128
Remote Config [baseline] (684.777 µs) : 0, 685
Remote Config [candidate] (661.893 µs) : 0, 662
Telemetry [baseline] (14.662 ms) : 0, 14662
Telemetry [candidate] (13.694 ms) : 0, 13694
section appsec
crashtracking [baseline] (1.453 ms) : 0, 1453
crashtracking [candidate] (1.458 ms) : 0, 1458
BytebuddyAgent [baseline] (758.351 ms) : 0, 758351
BytebuddyAgent [candidate] (759.731 ms) : 0, 759731
GlobalTracer [baseline] (236.362 ms) : 0, 236362
GlobalTracer [candidate] (235.179 ms) : 0, 235179
IAST [baseline] (23.809 ms) : 0, 23809
IAST [candidate] (23.606 ms) : 0, 23606
AppSec [baseline] (170.538 ms) : 0, 170538
AppSec [candidate] (169.938 ms) : 0, 169938
Debugger [baseline] (5.894 ms) : 0, 5894
Debugger [candidate] (7.36 ms) : 0, 7360
Remote Config [baseline] (651.726 µs) : 0, 652
Remote Config [candidate] (632.672 µs) : 0, 633
Telemetry [baseline] (10.063 ms) : 0, 10063
Telemetry [candidate] (8.439 ms) : 0, 8439
section iast
crashtracking [baseline] (1.45 ms) : 0, 1450
crashtracking [candidate] (1.455 ms) : 0, 1455
BytebuddyAgent [baseline] (852.125 ms) : 0, 852125
BytebuddyAgent [candidate] (857.627 ms) : 0, 857627
GlobalTracer [baseline] (233.517 ms) : 0, 233517
GlobalTracer [candidate] (234.403 ms) : 0, 234403
IAST [baseline] (29.458 ms) : 0, 29458
IAST [candidate] (30.938 ms) : 0, 30938
AppSec [baseline] (26.992 ms) : 0, 26992
AppSec [candidate] (26.891 ms) : 0, 26891
Debugger [baseline] (7.525 ms) : 0, 7525
Debugger [candidate] (6.703 ms) : 0, 6703
Remote Config [baseline] (602.567 µs) : 0, 603
Remote Config [candidate] (625.927 µs) : 0, 626
Telemetry [baseline] (8.216 ms) : 0, 8216
Telemetry [candidate] (8.372 ms) : 0, 8372
section profiling
crashtracking [baseline] (1.448 ms) : 0, 1448
crashtracking [candidate] (1.45 ms) : 0, 1450
BytebuddyAgent [baseline] (763.08 ms) : 0, 763080
BytebuddyAgent [candidate] (762.812 ms) : 0, 762812
GlobalTracer [baseline] (222.556 ms) : 0, 222556
GlobalTracer [candidate] (222.008 ms) : 0, 222008
AppSec [baseline] (30.119 ms) : 0, 30119
AppSec [candidate] (29.961 ms) : 0, 29961
Debugger [baseline] (7.079 ms) : 0, 7079
Debugger [candidate] (6.282 ms) : 0, 6282
Remote Config [baseline] (714.066 µs) : 0, 714
Remote Config [candidate] (686.63 µs) : 0, 687
Telemetry [baseline] (14.767 ms) : 0, 14767
Telemetry [candidate] (16.367 ms) : 0, 16367
ProfilingAgent [baseline] (108.548 ms) : 0, 108548
ProfilingAgent [candidate] (107.778 ms) : 0, 107778
Profiling [baseline] (109.193 ms) : 0, 109193
Profiling [candidate] (108.443 ms) : 0, 108443
LoadParameters
See matching parameters
SummaryFound 3 performance improvements and 2 performance regressions! Performance is the same for 7 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.53.0-SNAPSHOT~9c53c2ee5f, baseline=1.53.0-SNAPSHOT~d07fee98fb
dateFormat X
axisFormat %s
section baseline
no_agent (4.466 ms) : 4407, 4524
. : milestone, 4466,
iast (9.458 ms) : 9302, 9614
. : milestone, 9458,
iast_FULL (13.91 ms) : 13629, 14192
. : milestone, 13910,
iast_GLOBAL (10.342 ms) : 10162, 10523
. : milestone, 10342,
profiling (8.584 ms) : 8455, 8713
. : milestone, 8584,
tracing (7.464 ms) : 7361, 7567
. : milestone, 7464,
section candidate
no_agent (4.282 ms) : 4231, 4333
. : milestone, 4282,
iast (9.421 ms) : 9255, 9586
. : milestone, 9421,
iast_FULL (14.034 ms) : 13756, 14312
. : milestone, 14034,
iast_GLOBAL (10.303 ms) : 10108, 10499
. : milestone, 10303,
profiling (9.052 ms) : 8891, 9213
. : milestone, 9052,
tracing (7.538 ms) : 7432, 7644
. : milestone, 7538,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.53.0-SNAPSHOT~9c53c2ee5f, baseline=1.53.0-SNAPSHOT~d07fee98fb
dateFormat X
axisFormat %s
section baseline
no_agent (37.921 ms) : 37608, 38233
. : milestone, 37921,
appsec (48.117 ms) : 47674, 48560
. : milestone, 48117,
code_origins (44.732 ms) : 44341, 45122
. : milestone, 44732,
iast (44.471 ms) : 44090, 44852
. : milestone, 44471,
profiling (48.486 ms) : 47989, 48984
. : milestone, 48486,
tracing (44.506 ms) : 44114, 44899
. : milestone, 44506,
section candidate
no_agent (36.13 ms) : 35836, 36425
. : milestone, 36130,
appsec (48.081 ms) : 47657, 48506
. : milestone, 48081,
code_origins (46.145 ms) : 45729, 46561
. : milestone, 46145,
iast (45.616 ms) : 45206, 46026
. : milestone, 45616,
profiling (46.717 ms) : 46233, 47201
. : milestone, 46717,
tracing (43.461 ms) : 43098, 43824
. : milestone, 43461,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 2 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.53.0-SNAPSHOT~9c53c2ee5f, baseline=1.53.0-SNAPSHOT~d07fee98fb
dateFormat X
axisFormat %s
section baseline
no_agent (1.473 ms) : 1461, 1484
. : milestone, 1473,
appsec (3.67 ms) : 3454, 3887
. : milestone, 3670,
iast (2.203 ms) : 2140, 2265
. : milestone, 2203,
iast_GLOBAL (2.244 ms) : 2181, 2307
. : milestone, 2244,
profiling (2.045 ms) : 1994, 2096
. : milestone, 2045,
tracing (2.015 ms) : 1965, 2064
. : milestone, 2015,
section candidate
no_agent (1.471 ms) : 1460, 1483
. : milestone, 1471,
appsec (3.664 ms) : 3446, 3881
. : milestone, 3664,
iast (2.196 ms) : 2134, 2259
. : milestone, 2196,
iast_GLOBAL (2.234 ms) : 2170, 2297
. : milestone, 2234,
profiling (2.491 ms) : 2320, 2662
. : milestone, 2491,
tracing (2.007 ms) : 1958, 2055
. : milestone, 2007,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.53.0-SNAPSHOT~9c53c2ee5f, baseline=1.53.0-SNAPSHOT~d07fee98fb
dateFormat X
axisFormat %s
section baseline
no_agent (15.55 s) : 15550000, 15550000
. : milestone, 15550000,
appsec (14.707 s) : 14707000, 14707000
. : milestone, 14707000,
iast (18.254 s) : 18254000, 18254000
. : milestone, 18254000,
iast_GLOBAL (17.856 s) : 17856000, 17856000
. : milestone, 17856000,
profiling (16.046 s) : 16046000, 16046000
. : milestone, 16046000,
tracing (14.686 s) : 14686000, 14686000
. : milestone, 14686000,
section candidate
no_agent (15.282 s) : 15282000, 15282000
. : milestone, 15282000,
appsec (14.673 s) : 14673000, 14673000
. : milestone, 14673000,
iast (18.602 s) : 18602000, 18602000
. : milestone, 18602000,
iast_GLOBAL (18.063 s) : 18063000, 18063000
. : milestone, 18063000,
profiling (15.133 s) : 15133000, 15133000
. : milestone, 15133000,
tracing (14.863 s) : 14863000, 14863000
. : milestone, 14863000,
|
What Does This Do
Set max JVM test version instead of Ignoring the test
Motivation
log4j1
reached EOL in 2015 and is not compatible with Java 25.Additional Notes
This pipeline runs with non-default JVMs, i.e. JDK 25 since it is currently still EA: https://gitlab.ddbuild.io/DataDog/apm-reliability/dd-trace-java/-/pipelines/75026563
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: https://datadoghq.atlassian.net/browse/LANGPLAT-706