-
Notifications
You must be signed in to change notification settings - Fork 312
Tests: implemented switch from logback
to slf4j-simple
when needed.
#9435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🎯 Code Coverage 🔗 Commit SHA: a2263f9 | Docs | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 48 metrics, 11 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.53.0-SNAPSHOT~a2263f90f2, baseline=1.53.0-SNAPSHOT~d07fee98fb
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.055 s) : 0, 1055482
Total [baseline] (8.644 s) : 0, 8644406
Agent [candidate] (1.048 s) : 0, 1048382
Total [candidate] (8.619 s) : 0, 8618759
section iast
Agent [baseline] (1.182 s) : 0, 1181680
Total [baseline] (9.348 s) : 0, 9347742
Agent [candidate] (1.182 s) : 0, 1182011
Total [candidate] (9.337 s) : 0, 9336859
gantt
title insecure-bank - break down per module: candidate=1.53.0-SNAPSHOT~a2263f90f2, baseline=1.53.0-SNAPSHOT~d07fee98fb
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.455 ms) : 0, 1455
crashtracking [candidate] (1.454 ms) : 0, 1454
BytebuddyAgent [baseline] (736.951 ms) : 0, 736951
BytebuddyAgent [candidate] (733.601 ms) : 0, 733601
GlobalTracer [baseline] (243.695 ms) : 0, 243695
GlobalTracer [candidate] (243.135 ms) : 0, 243135
AppSec [baseline] (30.213 ms) : 0, 30213
AppSec [candidate] (30.224 ms) : 0, 30224
Debugger [baseline] (6.058 ms) : 0, 6058
Debugger [candidate] (6.065 ms) : 0, 6065
Remote Config [baseline] (677.12 µs) : 0, 677
Remote Config [candidate] (677.358 µs) : 0, 677
Telemetry [baseline] (15.367 ms) : 0, 15367
Telemetry [candidate] (12.268 ms) : 0, 12268
section iast
crashtracking [baseline] (1.453 ms) : 0, 1453
crashtracking [candidate] (1.452 ms) : 0, 1452
BytebuddyAgent [baseline] (852.785 ms) : 0, 852785
BytebuddyAgent [candidate] (852.56 ms) : 0, 852560
GlobalTracer [baseline] (233.51 ms) : 0, 233510
GlobalTracer [candidate] (233.636 ms) : 0, 233636
IAST [baseline] (29.568 ms) : 0, 29568
IAST [candidate] (29.683 ms) : 0, 29683
AppSec [baseline] (26.857 ms) : 0, 26857
AppSec [candidate] (27.985 ms) : 0, 27985
Debugger [baseline] (7.548 ms) : 0, 7548
Debugger [candidate] (6.623 ms) : 0, 6623
Remote Config [baseline] (606.157 µs) : 0, 606
Remote Config [candidate] (611.317 µs) : 0, 611
Telemetry [baseline] (8.331 ms) : 0, 8331
Telemetry [candidate] (8.329 ms) : 0, 8329
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.53.0-SNAPSHOT~a2263f90f2, baseline=1.53.0-SNAPSHOT~d07fee98fb
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.048 s) : 0, 1048370
Total [baseline] (10.738 s) : 0, 10738165
Agent [candidate] (1.05 s) : 0, 1049551
Total [candidate] (10.856 s) : 0, 10855627
section appsec
Agent [baseline] (1.236 s) : 0, 1236134
Total [baseline] (10.781 s) : 0, 10780971
Agent [candidate] (1.222 s) : 0, 1222123
Total [candidate] (10.857 s) : 0, 10857231
section iast
Agent [baseline] (1.195 s) : 0, 1194945
Total [baseline] (11.049 s) : 0, 11049032
Agent [candidate] (1.185 s) : 0, 1184787
Total [candidate] (11.017 s) : 0, 11016676
section profiling
Agent [baseline] (1.198 s) : 0, 1197923
Total [baseline] (10.912 s) : 0, 10911745
Agent [candidate] (1.199 s) : 0, 1198859
Total [candidate] (10.961 s) : 0, 10960569
gantt
title petclinic - break down per module: candidate=1.53.0-SNAPSHOT~a2263f90f2, baseline=1.53.0-SNAPSHOT~d07fee98fb
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.452 ms) : 0, 1452
crashtracking [candidate] (1.465 ms) : 0, 1465
BytebuddyAgent [baseline] (733.934 ms) : 0, 733934
BytebuddyAgent [candidate] (733.494 ms) : 0, 733494
GlobalTracer [baseline] (243.543 ms) : 0, 243543
GlobalTracer [candidate] (244.477 ms) : 0, 244477
AppSec [baseline] (30.192 ms) : 0, 30192
AppSec [candidate] (30.564 ms) : 0, 30564
Debugger [baseline] (6.088 ms) : 0, 6088
Debugger [candidate] (6.121 ms) : 0, 6121
Remote Config [baseline] (666.306 µs) : 0, 666
Remote Config [candidate] (676.128 µs) : 0, 676
Telemetry [baseline] (11.459 ms) : 0, 11459
Telemetry [candidate] (11.631 ms) : 0, 11631
section appsec
crashtracking [baseline] (1.471 ms) : 0, 1471
crashtracking [candidate] (1.446 ms) : 0, 1446
BytebuddyAgent [baseline] (762.863 ms) : 0, 762863
BytebuddyAgent [candidate] (754.12 ms) : 0, 754120
GlobalTracer [baseline] (238.747 ms) : 0, 238747
GlobalTracer [candidate] (235.374 ms) : 0, 235374
IAST [baseline] (24.086 ms) : 0, 24086
IAST [candidate] (23.48 ms) : 0, 23480
AppSec [baseline] (171.153 ms) : 0, 171153
AppSec [candidate] (170.833 ms) : 0, 170833
Debugger [baseline] (5.798 ms) : 0, 5798
Debugger [candidate] (6.664 ms) : 0, 6664
Remote Config [baseline] (653.303 µs) : 0, 653
Remote Config [candidate] (651.506 µs) : 0, 652
Telemetry [baseline] (10.074 ms) : 0, 10074
Telemetry [candidate] (8.454 ms) : 0, 8454
section iast
crashtracking [baseline] (1.463 ms) : 0, 1463
crashtracking [candidate] (1.446 ms) : 0, 1446
BytebuddyAgent [baseline] (862.321 ms) : 0, 862321
BytebuddyAgent [candidate] (854.739 ms) : 0, 854739
GlobalTracer [baseline] (236.1 ms) : 0, 236100
GlobalTracer [candidate] (234.357 ms) : 0, 234357
IAST [baseline] (29.035 ms) : 0, 29035
IAST [candidate] (29.81 ms) : 0, 29810
AppSec [baseline] (27.166 ms) : 0, 27166
AppSec [candidate] (28.673 ms) : 0, 28673
Debugger [baseline] (8.57 ms) : 0, 8570
Debugger [candidate] (5.747 ms) : 0, 5747
Remote Config [baseline] (635.869 µs) : 0, 636
Remote Config [candidate] (607.407 µs) : 0, 607
Telemetry [baseline] (8.382 ms) : 0, 8382
Telemetry [candidate] (8.291 ms) : 0, 8291
section profiling
crashtracking [baseline] (1.438 ms) : 0, 1438
crashtracking [candidate] (1.422 ms) : 0, 1422
BytebuddyAgent [baseline] (763.823 ms) : 0, 763823
BytebuddyAgent [candidate] (763.669 ms) : 0, 763669
GlobalTracer [baseline] (222.062 ms) : 0, 222062
GlobalTracer [candidate] (222.361 ms) : 0, 222361
AppSec [baseline] (29.987 ms) : 0, 29987
AppSec [candidate] (30.185 ms) : 0, 30185
Debugger [baseline] (6.261 ms) : 0, 6261
Debugger [candidate] (6.247 ms) : 0, 6247
Remote Config [baseline] (705.125 µs) : 0, 705
Remote Config [candidate] (695.109 µs) : 0, 695
Telemetry [baseline] (16.273 ms) : 0, 16273
Telemetry [candidate] (16.438 ms) : 0, 16438
ProfilingAgent [baseline] (107.642 ms) : 0, 107642
ProfilingAgent [candidate] (108.216 ms) : 0, 108216
Profiling [baseline] (108.293 ms) : 0, 108293
Profiling [candidate] (108.891 ms) : 0, 108891
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 12 unstable metrics. Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.53.0-SNAPSHOT~a2263f90f2, baseline=1.53.0-SNAPSHOT~d07fee98fb
dateFormat X
axisFormat %s
section baseline
no_agent (37.576 ms) : 37269, 37882
. : milestone, 37576,
appsec (48.229 ms) : 47775, 48683
. : milestone, 48229,
code_origins (44.986 ms) : 44596, 45376
. : milestone, 44986,
iast (44.195 ms) : 43814, 44576
. : milestone, 44195,
profiling (46.582 ms) : 46139, 47025
. : milestone, 46582,
tracing (44.692 ms) : 44310, 45074
. : milestone, 44692,
section candidate
no_agent (37.33 ms) : 37032, 37628
. : milestone, 37330,
appsec (47.218 ms) : 46789, 47646
. : milestone, 47218,
code_origins (45.108 ms) : 44723, 45492
. : milestone, 45108,
iast (44.18 ms) : 43795, 44565
. : milestone, 44180,
profiling (47.035 ms) : 46594, 47476
. : milestone, 47035,
tracing (43.909 ms) : 43548, 44269
. : milestone, 43909,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.53.0-SNAPSHOT~a2263f90f2, baseline=1.53.0-SNAPSHOT~d07fee98fb
dateFormat X
axisFormat %s
section baseline
no_agent (4.333 ms) : 4277, 4389
. : milestone, 4333,
iast (9.065 ms) : 8922, 9209
. : milestone, 9065,
iast_FULL (13.886 ms) : 13611, 14161
. : milestone, 13886,
iast_GLOBAL (10.389 ms) : 10201, 10577
. : milestone, 10389,
profiling (8.715 ms) : 8575, 8856
. : milestone, 8715,
tracing (7.404 ms) : 7300, 7509
. : milestone, 7404,
section candidate
no_agent (4.267 ms) : 4220, 4315
. : milestone, 4267,
iast (9.128 ms) : 8971, 9285
. : milestone, 9128,
iast_FULL (13.581 ms) : 13312, 13850
. : milestone, 13581,
iast_GLOBAL (10.683 ms) : 10477, 10888
. : milestone, 10683,
profiling (8.968 ms) : 8818, 9119
. : milestone, 8968,
tracing (7.338 ms) : 7237, 7440
. : milestone, 7338,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.53.0-SNAPSHOT~a2263f90f2, baseline=1.53.0-SNAPSHOT~d07fee98fb
dateFormat X
axisFormat %s
section baseline
no_agent (1.477 ms) : 1465, 1488
. : milestone, 1477,
appsec (3.652 ms) : 3436, 3869
. : milestone, 3652,
iast (2.208 ms) : 2145, 2272
. : milestone, 2208,
iast_GLOBAL (2.239 ms) : 2176, 2302
. : milestone, 2239,
profiling (2.053 ms) : 2002, 2104
. : milestone, 2053,
tracing (2.04 ms) : 1991, 2090
. : milestone, 2040,
section candidate
no_agent (1.475 ms) : 1464, 1487
. : milestone, 1475,
appsec (3.663 ms) : 3447, 3879
. : milestone, 3663,
iast (2.201 ms) : 2138, 2264
. : milestone, 2201,
iast_GLOBAL (2.254 ms) : 2191, 2317
. : milestone, 2254,
profiling (2.057 ms) : 2006, 2109
. : milestone, 2057,
tracing (2.024 ms) : 1974, 2073
. : milestone, 2024,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.53.0-SNAPSHOT~a2263f90f2, baseline=1.53.0-SNAPSHOT~d07fee98fb
dateFormat X
axisFormat %s
section baseline
no_agent (14.824 s) : 14824000, 14824000
. : milestone, 14824000,
appsec (14.674 s) : 14674000, 14674000
. : milestone, 14674000,
iast (18.227 s) : 18227000, 18227000
. : milestone, 18227000,
iast_GLOBAL (17.96 s) : 17960000, 17960000
. : milestone, 17960000,
profiling (15.724 s) : 15724000, 15724000
. : milestone, 15724000,
tracing (14.897 s) : 14897000, 14897000
. : milestone, 14897000,
section candidate
no_agent (14.947 s) : 14947000, 14947000
. : milestone, 14947000,
appsec (14.779 s) : 14779000, 14779000
. : milestone, 14779000,
iast (18.264 s) : 18264000, 18264000
. : milestone, 18264000,
iast_GLOBAL (18.246 s) : 18246000, 18246000
. : milestone, 18246000,
profiling (15.462 s) : 15462000, 15462000
. : milestone, 15462000,
tracing (15.054 s) : 15054000, 15054000
. : milestone, 15054000,
|
dd-java-agent/testing/src/main/groovy/datadog/trace/agent/test/AgentTestRunner.groovy
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice solution
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
What Does This Do
Tests: implemented switch from
logback
toslf4j-simple
when needed.Motivation
Green CI.
Additional Notes
Use slf4j-simple as default; logback has a high chance of getting stuck in a deadlock on CI.