-
Notifications
You must be signed in to change notification settings - Fork 312
Daniel.mohedano/logs backend logging #9411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
) * Make rum injector stream/writer more resilient to errors (cherry picked from commit a298c60) * fix tests (cherry picked from commit 62acf7c) * fix tests (cherry picked from commit 5a32d51) * Update dd-java-agent/agent-bootstrap/src/main/java/datadog/trace/bootstrap/instrumentation/buffer/InjectingPipeOutputStream.java Co-authored-by: Stuart McCulloch <[email protected]> (cherry picked from commit 87d15fb) * apply suggestions (cherry picked from commit 21afeb2) --------- Co-authored-by: Stuart McCulloch <[email protected]>
#9342) * Make rum injector stream/writer more resilient to errors (cherry picked from commit 36246b4) * fix tests (cherry picked from commit 993bf57) * Improve RUM injection matching and avoid truncating responses (cherry picked from commit f46c8f1) * Use MH for setContentLengthLong since available from 3.1 (cherry picked from commit 13753c1) * Fix tomcat11 tests (cherry picked from commit 4fb4129) * Update dd-smoke-tests/rum/src/main/groovy/datadog/smoketest/rum/AbstractRumServerSmokeTest.groovy Co-authored-by: Bruce Bujon <[email protected]> (cherry picked from commit 4b44a38) * Update dd-smoke-tests/rum/src/main/groovy/datadog/smoketest/rum/AbstractRumServerSmokeTest.groovy Co-authored-by: Bruce Bujon <[email protected]> (cherry picked from commit d7e1fdf) * remove leftover (cherry picked from commit 22e5389) --------- Co-authored-by: Bruce Bujon <[email protected]>
Backport #9355 to release/v1.52.x
(cherry picked from commit ffa80b2)
🎯 Code Coverage 🔗 Commit SHA: 9916a8a | Docs | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 44 metrics, 15 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.53.0-SNAPSHOT~9916a8adf4, baseline=1.53.0-SNAPSHOT~7224c81311
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.05 s) : 0, 1050296
Total [baseline] (8.631 s) : 0, 8630668
Agent [candidate] (1.053 s) : 0, 1053006
Total [candidate] (8.66 s) : 0, 8659690
section iast
Agent [baseline] (1.189 s) : 0, 1189071
Total [baseline] (9.363 s) : 0, 9362809
Agent [candidate] (1.185 s) : 0, 1185291
Total [candidate] (9.384 s) : 0, 9384085
gantt
title insecure-bank - break down per module: candidate=1.53.0-SNAPSHOT~9916a8adf4, baseline=1.53.0-SNAPSHOT~7224c81311
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.467 ms) : 0, 1467
crashtracking [candidate] (1.484 ms) : 0, 1484
BytebuddyAgent [baseline] (735.617 ms) : 0, 735617
BytebuddyAgent [candidate] (736.485 ms) : 0, 736485
GlobalTracer [baseline] (243.044 ms) : 0, 243044
GlobalTracer [candidate] (243.99 ms) : 0, 243990
AppSec [baseline] (30.224 ms) : 0, 30224
AppSec [candidate] (30.396 ms) : 0, 30396
Debugger [baseline] (6.07 ms) : 0, 6070
Debugger [candidate] (6.094 ms) : 0, 6094
Remote Config [baseline] (671.876 µs) : 0, 672
Remote Config [candidate] (689.173 µs) : 0, 689
Telemetry [baseline] (12.194 ms) : 0, 12194
Telemetry [candidate] (12.768 ms) : 0, 12768
section iast
crashtracking [baseline] (1.472 ms) : 0, 1472
crashtracking [candidate] (1.454 ms) : 0, 1454
BytebuddyAgent [baseline] (858.78 ms) : 0, 858780
BytebuddyAgent [candidate] (854.562 ms) : 0, 854562
GlobalTracer [baseline] (234.505 ms) : 0, 234505
GlobalTracer [candidate] (234.698 ms) : 0, 234698
AppSec [baseline] (27.857 ms) : 0, 27857
AppSec [candidate] (29.151 ms) : 0, 29151
Debugger [baseline] (6.61 ms) : 0, 6610
Debugger [candidate] (6.693 ms) : 0, 6693
Remote Config [baseline] (607.147 µs) : 0, 607
Remote Config [candidate] (622.095 µs) : 0, 622
Telemetry [baseline] (8.398 ms) : 0, 8398
Telemetry [candidate] (8.251 ms) : 0, 8251
IAST [baseline] (29.692 ms) : 0, 29692
IAST [candidate] (28.721 ms) : 0, 28721
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.53.0-SNAPSHOT~9916a8adf4, baseline=1.53.0-SNAPSHOT~7224c81311
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.054 s) : 0, 1053844
Total [baseline] (10.673 s) : 0, 10673480
Agent [candidate] (1.059 s) : 0, 1059345
Total [candidate] (10.922 s) : 0, 10922055
section appsec
Agent [baseline] (1.223 s) : 0, 1223112
Total [baseline] (10.03 s) : 0, 10029617
Agent [candidate] (1.23 s) : 0, 1229503
Total [candidate] (10.786 s) : 0, 10785527
section iast
Agent [baseline] (1.197 s) : 0, 1196958
Total [baseline] (11.042 s) : 0, 11041741
Agent [candidate] (1.186 s) : 0, 1186267
Total [candidate] (10.994 s) : 0, 10994181
section profiling
Agent [baseline] (1.199 s) : 0, 1199028
Total [baseline] (10.966 s) : 0, 10966047
Agent [candidate] (1.201 s) : 0, 1200609
Total [candidate] (10.965 s) : 0, 10964581
gantt
title petclinic - break down per module: candidate=1.53.0-SNAPSHOT~9916a8adf4, baseline=1.53.0-SNAPSHOT~7224c81311
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.475 ms) : 0, 1475
crashtracking [candidate] (1.473 ms) : 0, 1473
BytebuddyAgent [baseline] (736.552 ms) : 0, 736552
BytebuddyAgent [candidate] (740.694 ms) : 0, 740694
GlobalTracer [baseline] (243.956 ms) : 0, 243956
GlobalTracer [candidate] (244.942 ms) : 0, 244942
AppSec [baseline] (30.264 ms) : 0, 30264
AppSec [candidate] (30.552 ms) : 0, 30552
Debugger [baseline] (6.072 ms) : 0, 6072
Debugger [candidate] (6.12 ms) : 0, 6120
Remote Config [baseline] (694.274 µs) : 0, 694
Remote Config [candidate] (681.449 µs) : 0, 681
Telemetry [baseline] (13.666 ms) : 0, 13666
Telemetry [candidate] (13.574 ms) : 0, 13574
section appsec
crashtracking [baseline] (1.457 ms) : 0, 1457
crashtracking [candidate] (1.46 ms) : 0, 1460
BytebuddyAgent [baseline] (755.845 ms) : 0, 755845
BytebuddyAgent [candidate] (759.085 ms) : 0, 759085
GlobalTracer [baseline] (234.964 ms) : 0, 234964
GlobalTracer [candidate] (237.447 ms) : 0, 237447
IAST [baseline] (23.537 ms) : 0, 23537
IAST [candidate] (23.793 ms) : 0, 23793
AppSec [baseline] (168.688 ms) : 0, 168688
AppSec [candidate] (168.713 ms) : 0, 168713
Debugger [baseline] (6.628 ms) : 0, 6628
Debugger [candidate] (8.908 ms) : 0, 8908
Remote Config [baseline] (672.123 µs) : 0, 672
Remote Config [candidate] (637.139 µs) : 0, 637
Telemetry [baseline] (10.135 ms) : 0, 10135
Telemetry [candidate] (8.304 ms) : 0, 8304
section iast
crashtracking [baseline] (1.484 ms) : 0, 1484
crashtracking [candidate] (1.453 ms) : 0, 1453
BytebuddyAgent [baseline] (864.519 ms) : 0, 864519
BytebuddyAgent [candidate] (855.448 ms) : 0, 855448
GlobalTracer [baseline] (235.919 ms) : 0, 235919
GlobalTracer [candidate] (234.447 ms) : 0, 234447
IAST [baseline] (28.316 ms) : 0, 28316
IAST [candidate] (31.189 ms) : 0, 31189
AppSec [baseline] (29.485 ms) : 0, 29485
AppSec [candidate] (26.847 ms) : 0, 26847
Debugger [baseline] (6.659 ms) : 0, 6659
Debugger [candidate] (6.819 ms) : 0, 6819
Remote Config [baseline] (602.522 µs) : 0, 603
Remote Config [candidate] (631.62 µs) : 0, 632
Telemetry [baseline] (8.531 ms) : 0, 8531
Telemetry [candidate] (8.232 ms) : 0, 8232
section profiling
crashtracking [baseline] (1.436 ms) : 0, 1436
crashtracking [candidate] (1.425 ms) : 0, 1425
BytebuddyAgent [baseline] (762.779 ms) : 0, 762779
BytebuddyAgent [candidate] (764.266 ms) : 0, 764266
GlobalTracer [baseline] (222.988 ms) : 0, 222988
GlobalTracer [candidate] (223.028 ms) : 0, 223028
AppSec [baseline] (30.878 ms) : 0, 30878
AppSec [candidate] (30.141 ms) : 0, 30141
Debugger [baseline] (7.101 ms) : 0, 7101
Debugger [candidate] (7.151 ms) : 0, 7151
Remote Config [baseline] (750.547 µs) : 0, 751
Remote Config [candidate] (707.822 µs) : 0, 708
Telemetry [baseline] (14.756 ms) : 0, 14756
Telemetry [candidate] (15.331 ms) : 0, 15331
ProfilingAgent [baseline] (107.988 ms) : 0, 107988
ProfilingAgent [candidate] (108.637 ms) : 0, 108637
Profiling [baseline] (108.627 ms) : 0, 108627
Profiling [candidate] (109.287 ms) : 0, 109287
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 4 performance regressions! Performance is the same for 8 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.53.0-SNAPSHOT~9916a8adf4, baseline=1.53.0-SNAPSHOT~7224c81311
dateFormat X
axisFormat %s
section baseline
no_agent (4.293 ms) : 4244, 4343
. : milestone, 4293,
iast (9.445 ms) : 9290, 9600
. : milestone, 9445,
iast_FULL (14.076 ms) : 13795, 14357
. : milestone, 14076,
iast_GLOBAL (10.059 ms) : 9884, 10235
. : milestone, 10059,
profiling (8.436 ms) : 8303, 8568
. : milestone, 8436,
tracing (7.372 ms) : 7270, 7474
. : milestone, 7372,
section candidate
no_agent (4.356 ms) : 4307, 4406
. : milestone, 4356,
iast (9.609 ms) : 9447, 9772
. : milestone, 9609,
iast_FULL (13.976 ms) : 13696, 14256
. : milestone, 13976,
iast_GLOBAL (10.286 ms) : 10104, 10468
. : milestone, 10286,
profiling (10.055 ms) : 9859, 10251
. : milestone, 10055,
tracing (7.844 ms) : 7718, 7970
. : milestone, 7844,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.53.0-SNAPSHOT~9916a8adf4, baseline=1.53.0-SNAPSHOT~7224c81311
dateFormat X
axisFormat %s
section baseline
no_agent (35.978 ms) : 35689, 36267
. : milestone, 35978,
appsec (47.829 ms) : 47398, 48260
. : milestone, 47829,
code_origins (44.589 ms) : 44206, 44972
. : milestone, 44589,
iast (43.79 ms) : 43412, 44169
. : milestone, 43790,
profiling (52.328 ms) : 51809, 52847
. : milestone, 52328,
tracing (43.791 ms) : 43412, 44171
. : milestone, 43791,
section candidate
no_agent (36.204 ms) : 35905, 36503
. : milestone, 36204,
appsec (48.613 ms) : 48175, 49051
. : milestone, 48613,
code_origins (44.595 ms) : 44210, 44980
. : milestone, 44595,
iast (46.199 ms) : 45796, 46603
. : milestone, 46199,
profiling (52.97 ms) : 52509, 53432
. : milestone, 52970,
tracing (45.17 ms) : 44770, 45570
. : milestone, 45170,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.53.0-SNAPSHOT~9916a8adf4, baseline=1.53.0-SNAPSHOT~7224c81311
dateFormat X
axisFormat %s
section baseline
no_agent (15.343 s) : 15343000, 15343000
. : milestone, 15343000,
appsec (14.863 s) : 14863000, 14863000
. : milestone, 14863000,
iast (18.494 s) : 18494000, 18494000
. : milestone, 18494000,
iast_GLOBAL (17.975 s) : 17975000, 17975000
. : milestone, 17975000,
profiling (15.276 s) : 15276000, 15276000
. : milestone, 15276000,
tracing (14.807 s) : 14807000, 14807000
. : milestone, 14807000,
section candidate
no_agent (14.994 s) : 14994000, 14994000
. : milestone, 14994000,
appsec (14.832 s) : 14832000, 14832000
. : milestone, 14832000,
iast (18.021 s) : 18021000, 18021000
. : milestone, 18021000,
iast_GLOBAL (17.818 s) : 17818000, 17818000
. : milestone, 17818000,
profiling (15.532 s) : 15532000, 15532000
. : milestone, 15532000,
tracing (15.151 s) : 15151000, 15151000
. : milestone, 15151000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.53.0-SNAPSHOT~9916a8adf4, baseline=1.53.0-SNAPSHOT~7224c81311
dateFormat X
axisFormat %s
section baseline
no_agent (1.479 ms) : 1467, 1490
. : milestone, 1479,
appsec (3.634 ms) : 3421, 3847
. : milestone, 3634,
iast (2.207 ms) : 2143, 2270
. : milestone, 2207,
iast_GLOBAL (2.248 ms) : 2185, 2311
. : milestone, 2248,
profiling (2.047 ms) : 1996, 2098
. : milestone, 2047,
tracing (2.031 ms) : 1982, 2080
. : milestone, 2031,
section candidate
no_agent (1.482 ms) : 1470, 1493
. : milestone, 1482,
appsec (3.683 ms) : 3466, 3899
. : milestone, 3683,
iast (2.212 ms) : 2149, 2275
. : milestone, 2212,
iast_GLOBAL (2.254 ms) : 2190, 2318
. : milestone, 2254,
profiling (2.059 ms) : 2009, 2110
. : milestone, 2059,
tracing (2.03 ms) : 1981, 2080
. : milestone, 2030,
|
What Does This Do
Motivation
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]