-
Notifications
You must be signed in to change notification settings - Fork 305
Support attaching tags to telemetry logs #8921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
smola
wants to merge
3
commits into
master
Choose a base branch
from
smola/telemetry-logs-tags
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sezen-datadog
approved these changes
Jun 4, 2025
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 40 metrics, 13 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.50.0-SNAPSHOT~79c4d114ee, baseline=1.50.0-SNAPSHOT~6db7d82c6e
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.027 s) : 0, 1026969
Total [baseline] (8.581 s) : 0, 8580664
Agent [candidate] (1.027 s) : 0, 1026948
Total [candidate] (8.526 s) : 0, 8526353
section iast
Agent [baseline] (1.154 s) : 0, 1153794
Total [baseline] (9.251 s) : 0, 9251163
Agent [candidate] (1.147 s) : 0, 1147497
Total [candidate] (9.189 s) : 0, 9189198
gantt
title insecure-bank - break down per module: candidate=1.50.0-SNAPSHOT~79c4d114ee, baseline=1.50.0-SNAPSHOT~6db7d82c6e
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (686.689 ms) : 0, 686689
BytebuddyAgent [candidate] (686.816 ms) : 0, 686816
GlobalTracer [baseline] (242.182 ms) : 0, 242182
GlobalTracer [candidate] (242.562 ms) : 0, 242562
AppSec [baseline] (59.09 ms) : 0, 59090
AppSec [candidate] (57.023 ms) : 0, 57023
Debugger [baseline] (6.234 ms) : 0, 6234
Debugger [candidate] (8.6 ms) : 0, 8600
Remote Config [baseline] (670.51 µs) : 0, 671
Remote Config [candidate] (674.524 µs) : 0, 675
Telemetry [baseline] (11.269 ms) : 0, 11269
Telemetry [candidate] (10.316 ms) : 0, 10316
section iast
BytebuddyAgent [baseline] (806.165 ms) : 0, 806165
BytebuddyAgent [candidate] (803.375 ms) : 0, 803375
GlobalTracer [baseline] (232.752 ms) : 0, 232752
GlobalTracer [candidate] (230.686 ms) : 0, 230686
IAST [baseline] (25.575 ms) : 0, 25575
IAST [candidate] (30.442 ms) : 0, 30442
AppSec [baseline] (53.817 ms) : 0, 53817
AppSec [candidate] (47.765 ms) : 0, 47765
Debugger [baseline] (5.958 ms) : 0, 5958
Debugger [candidate] (5.914 ms) : 0, 5914
Remote Config [baseline] (603.036 µs) : 0, 603
Remote Config [candidate] (605.043 µs) : 0, 605
Telemetry [baseline] (8.023 ms) : 0, 8023
Telemetry [candidate] (8.007 ms) : 0, 8007
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.50.0-SNAPSHOT~79c4d114ee, baseline=1.50.0-SNAPSHOT~6db7d82c6e
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.025 s) : 0, 1024665
Total [baseline] (10.541 s) : 0, 10540847
Agent [candidate] (1.027 s) : 0, 1026632
Total [candidate] (10.57 s) : 0, 10569600
section appsec
Agent [baseline] (1.178 s) : 0, 1178451
Total [baseline] (10.744 s) : 0, 10744154
Agent [candidate] (1.177 s) : 0, 1177166
Total [candidate] (10.71 s) : 0, 10709740
section iast
Agent [baseline] (1.153 s) : 0, 1152871
Total [baseline] (10.908 s) : 0, 10908009
Agent [candidate] (1.159 s) : 0, 1159146
Total [candidate] (11.058 s) : 0, 11058117
section profiling
Agent [baseline] (1.269 s) : 0, 1269458
Total [baseline] (10.94 s) : 0, 10939700
Agent [candidate] (1.268 s) : 0, 1267905
Total [candidate] (10.932 s) : 0, 10932002
gantt
title petclinic - break down per module: candidate=1.50.0-SNAPSHOT~79c4d114ee, baseline=1.50.0-SNAPSHOT~6db7d82c6e
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (685.05 ms) : 0, 685050
BytebuddyAgent [candidate] (685.909 ms) : 0, 685909
GlobalTracer [baseline] (241.373 ms) : 0, 241373
GlobalTracer [candidate] (242.4 ms) : 0, 242400
AppSec [baseline] (56.962 ms) : 0, 56962
AppSec [candidate] (56.918 ms) : 0, 56918
Debugger [baseline] (6.311 ms) : 0, 6311
Debugger [candidate] (8.534 ms) : 0, 8534
Remote Config [baseline] (673.124 µs) : 0, 673
Remote Config [candidate] (691.091 µs) : 0, 691
Telemetry [baseline] (13.501 ms) : 0, 13501
Telemetry [candidate] (11.235 ms) : 0, 11235
section appsec
BytebuddyAgent [baseline] (711.29 ms) : 0, 711290
BytebuddyAgent [candidate] (709.39 ms) : 0, 709390
GlobalTracer [baseline] (235.038 ms) : 0, 235038
GlobalTracer [candidate] (235.662 ms) : 0, 235662
AppSec [baseline] (175.734 ms) : 0, 175734
AppSec [candidate] (175.64 ms) : 0, 175640
Debugger [baseline] (5.894 ms) : 0, 5894
Debugger [candidate] (5.91 ms) : 0, 5910
Remote Config [baseline] (606.648 µs) : 0, 607
Remote Config [candidate] (634.419 µs) : 0, 634
Telemetry [baseline] (7.165 ms) : 0, 7165
Telemetry [candidate] (7.207 ms) : 0, 7207
IAST [baseline] (21.815 ms) : 0, 21815
IAST [candidate] (21.868 ms) : 0, 21868
section iast
BytebuddyAgent [baseline] (806.608 ms) : 0, 806608
BytebuddyAgent [candidate] (808.816 ms) : 0, 808816
GlobalTracer [baseline] (232.04 ms) : 0, 232040
GlobalTracer [candidate] (234.168 ms) : 0, 234168
AppSec [baseline] (51.298 ms) : 0, 51298
AppSec [candidate] (52.157 ms) : 0, 52157
Debugger [baseline] (5.947 ms) : 0, 5947
Debugger [candidate] (6.058 ms) : 0, 6058
Remote Config [baseline] (613.964 µs) : 0, 614
Remote Config [candidate] (622.112 µs) : 0, 622
Telemetry [baseline] (8.1 ms) : 0, 8100
Telemetry [candidate] (8.227 ms) : 0, 8227
IAST [baseline] (27.519 ms) : 0, 27519
IAST [candidate] (28.194 ms) : 0, 28194
section profiling
ProfilingAgent [baseline] (106.05 ms) : 0, 106050
ProfilingAgent [candidate] (105.358 ms) : 0, 105358
BytebuddyAgent [baseline] (676.426 ms) : 0, 676426
BytebuddyAgent [candidate] (675.918 ms) : 0, 675918
GlobalTracer [baseline] (361.03 ms) : 0, 361030
GlobalTracer [candidate] (361.366 ms) : 0, 361366
AppSec [baseline] (62.436 ms) : 0, 62436
AppSec [candidate] (61.85 ms) : 0, 61850
Debugger [baseline] (6.14 ms) : 0, 6140
Debugger [candidate] (6.105 ms) : 0, 6105
Remote Config [baseline] (720.424 µs) : 0, 720
Remote Config [candidate] (700.938 µs) : 0, 701
Telemetry [baseline] (8.138 ms) : 0, 8138
Telemetry [candidate] (8.124 ms) : 0, 8124
Profiling [baseline] (106.075 ms) : 0, 106075
Profiling [candidate] (105.382 ms) : 0, 105382
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 2 performance regressions! Performance is the same for 9 metrics, 12 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.50.0-SNAPSHOT~79c4d114ee, baseline=1.50.0-SNAPSHOT~6db7d82c6e
dateFormat X
axisFormat %s
section baseline
no_agent (37.116 ms) : 36830, 37401
. : milestone, 37116,
appsec (46.897 ms) : 46477, 47317
. : milestone, 46897,
code_origins (44.401 ms) : 44052, 44750
. : milestone, 44401,
iast (45.579 ms) : 45186, 45972
. : milestone, 45579,
profiling (47.223 ms) : 46751, 47694
. : milestone, 47223,
tracing (43.012 ms) : 42665, 43360
. : milestone, 43012,
section candidate
no_agent (36.831 ms) : 36531, 37130
. : milestone, 36831,
appsec (47.646 ms) : 47219, 48073
. : milestone, 47646,
code_origins (47.563 ms) : 47176, 47951
. : milestone, 47563,
iast (45.115 ms) : 44726, 45504
. : milestone, 45115,
profiling (47.948 ms) : 47488, 48407
. : milestone, 47948,
tracing (42.213 ms) : 41887, 42538
. : milestone, 42213,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.50.0-SNAPSHOT~79c4d114ee, baseline=1.50.0-SNAPSHOT~6db7d82c6e
dateFormat X
axisFormat %s
section baseline
no_agent (4.538 ms) : 4485, 4591
. : milestone, 4538,
iast (8.838 ms) : 8688, 8987
. : milestone, 8838,
iast_FULL (13.746 ms) : 13477, 14015
. : milestone, 13746,
iast_GLOBAL (10.172 ms) : 9994, 10350
. : milestone, 10172,
profiling (8.943 ms) : 8802, 9084
. : milestone, 8943,
tracing (7.427 ms) : 7325, 7530
. : milestone, 7427,
section candidate
no_agent (4.374 ms) : 4325, 4424
. : milestone, 4374,
iast (9.21 ms) : 9062, 9358
. : milestone, 9210,
iast_FULL (14.162 ms) : 13887, 14437
. : milestone, 14162,
iast_GLOBAL (10.353 ms) : 10173, 10533
. : milestone, 10353,
profiling (8.849 ms) : 8707, 8992
. : milestone, 8849,
tracing (7.649 ms) : 7534, 7764
. : milestone, 7649,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~79c4d114ee, baseline=1.50.0-SNAPSHOT~6db7d82c6e
dateFormat X
axisFormat %s
section baseline
no_agent (14.954 s) : 14954000, 14954000
. : milestone, 14954000,
appsec (15.689 s) : 15689000, 15689000
. : milestone, 15689000,
iast (18.749 s) : 18749000, 18749000
. : milestone, 18749000,
iast_GLOBAL (17.995 s) : 17995000, 17995000
. : milestone, 17995000,
profiling (15.293 s) : 15293000, 15293000
. : milestone, 15293000,
tracing (14.976 s) : 14976000, 14976000
. : milestone, 14976000,
section candidate
no_agent (15.489 s) : 15489000, 15489000
. : milestone, 15489000,
appsec (14.841 s) : 14841000, 14841000
. : milestone, 14841000,
iast (18.701 s) : 18701000, 18701000
. : milestone, 18701000,
iast_GLOBAL (18.046 s) : 18046000, 18046000
. : milestone, 18046000,
profiling (15.303 s) : 15303000, 15303000
. : milestone, 15303000,
tracing (15.019 s) : 15019000, 15019000
. : milestone, 15019000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~79c4d114ee, baseline=1.50.0-SNAPSHOT~6db7d82c6e
dateFormat X
axisFormat %s
section baseline
no_agent (1.482 ms) : 1471, 1494
. : milestone, 1482,
appsec (2.413 ms) : 2364, 2462
. : milestone, 2413,
iast (2.196 ms) : 2135, 2258
. : milestone, 2196,
iast_GLOBAL (2.236 ms) : 2175, 2298
. : milestone, 2236,
profiling (2.03 ms) : 1981, 2078
. : milestone, 2030,
tracing (2.011 ms) : 1964, 2058
. : milestone, 2011,
section candidate
no_agent (1.484 ms) : 1472, 1495
. : milestone, 1484,
appsec (2.412 ms) : 2363, 2460
. : milestone, 2412,
iast (2.194 ms) : 2133, 2255
. : milestone, 2194,
iast_GLOBAL (2.233 ms) : 2172, 2295
. : milestone, 2233,
profiling (2.057 ms) : 2006, 2107
. : milestone, 2057,
tracing (2.007 ms) : 1960, 2055
. : milestone, 2007,
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Add support for
LogCollector
to create telemetry logs with tags. Tags are defined as a string, a comma-separated list, e.g.tag1:value1,tag2:value2
.Motivation
We have new use cases in AppSec to send telemetry logs with more structured data in tags. This functionality was already in our telemetry system, but not exposed in
internal-api
.This is still not exposed via regular SLF4J logging integration. For the time being, if one needs this, they'll have to use the telemetry-specific interface in this PR.
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]