fix(ddtrace/tracer): replace RLock with Lock for NoDebugStack check to prevent race condition #3446
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Reduces to a single locking operation everything in
Finish
'sNoDebugStack
.Motivation
Per @felixge's comment, there is a potential race condition in the
NoDebugStack
when finishing a span.Reviewer's Checklist
golangci-lint run
locally.Unsure? Have a question? Request a review!