Skip to content

[AAP] Add "100.65.0.0/10" as a private IP range #7461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 4, 2025
Merged

[AAP] Add "100.65.0.0/10" as a private IP range #7461

merged 1 commit into from
Sep 4, 2025

Conversation

daniel-romano-DD
Copy link
Contributor

@daniel-romano-DD daniel-romano-DD commented Sep 3, 2025 •
edited
Loading

Summary of changes

Add new IP4 range as private

Reason for change

JIRA

Implementation details

Test coverage

Added unit tests

Other details

@dd-trace-dotnet-ci-bot
Copy link

dd-trace-dotnet-ci-bot bot commented Sep 3, 2025 •
edited
Loading

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7461) - mean (73ms)  : 72, 75
     .   : milestone, 73,
    master - mean (73ms)  : 71, 75
     .   : milestone, 73,

    section Baseline
    This PR (7461) - mean (70ms)  : 66, 73
     .   : milestone, 70,
    master - mean (70ms)  : 64, 77
     .   : milestone, 70,

    section CallTarget+Inlining+NGEN
    This PR (7461) - mean (997ms)  : 974, 1020
     .   : milestone, 997,
    master - mean (994ms)  : 971, 1017
     .   : milestone, 994,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7461) - mean (109ms)  : 108, 111
     .   : milestone, 109,
    master - mean (109ms)  : 107, 111
     .   : milestone, 109,

    section Baseline
    This PR (7461) - mean (108ms)  : 106, 110
     .   : milestone, 108,
    master - mean (108ms)  : 105, 111
     .   : milestone, 108,

    section CallTarget+Inlining+NGEN
    This PR (7461) - mean (708ms)  : 682, 735
     .   : milestone, 708,
    master - mean (706ms)  : 685, 728
     .   : milestone, 706,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7461) - mean (96ms)  : 94, 98
     .   : milestone, 96,
    master - mean (96ms)  : 95, 98
     .   : milestone, 96,

    section Baseline
    This PR (7461) - mean (96ms)  : 93, 98
     .   : milestone, 96,
    master - mean (96ms)  : 94, 98
     .   : milestone, 96,

    section CallTarget+Inlining+NGEN
    This PR (7461) - mean (661ms)  : 639, 683
     .   : milestone, 661,
    master - mean (664ms)  : 644, 684
     .   : milestone, 664,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7461) - mean (95ms)  : 93, 97
     .   : milestone, 95,
    master - mean (95ms)  : 94, 97
     .   : milestone, 95,

    section Baseline
    This PR (7461) - mean (94ms)  : 92, 96
     .   : milestone, 94,
    master - mean (94ms)  : 92, 96
     .   : milestone, 94,

    section CallTarget+Inlining+NGEN
    This PR (7461) - mean (596ms)  : 582, 611
     .   : milestone, 596,
    master - mean (601ms)  : 588, 613
     .   : milestone, 601,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7461) - mean (200ms)  : 195, 204
     .   : milestone, 200,
    master - mean (196ms)  : 192, 200
     .   : milestone, 196,

    section Baseline
    This PR (7461) - mean (197ms)  : 191, 203
     .   : milestone, 197,
    master - mean (192ms)  : 187, 197
     .   : milestone, 192,

    section CallTarget+Inlining+NGEN
    This PR (7461) - mean (1,129ms)  : 1091, 1168
     .   : milestone, 1129,
    master - mean (1,107ms)  : 1066, 1149
     .   : milestone, 1107,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7461) - mean (283ms)  : 278, 288
     .   : milestone, 283,
    master - mean (279ms)  : 272, 287
     .   : milestone, 279,

    section Baseline
    This PR (7461) - mean (282ms)  : 276, 288
     .   : milestone, 282,
    master - mean (277ms)  : 272, 281
     .   : milestone, 277,

    section CallTarget+Inlining+NGEN
    This PR (7461) - mean (915ms)  : 880, 950
     .   : milestone, 915,
    master - mean (901ms)  : 864, 939
     .   : milestone, 901,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7461) - mean (277ms)  : 270, 283
     .   : milestone, 277,
    master - mean (270ms)  : 266, 275
     .   : milestone, 270,

    section Baseline
    This PR (7461) - mean (275ms)  : 269, 280
     .   : milestone, 275,
    master - mean (271ms)  : 264, 279
     .   : milestone, 271,

    section CallTarget+Inlining+NGEN
    This PR (7461) - mean (905ms)  : 868, 943
     .   : milestone, 905,
    master - mean (883ms)  : 849, 917
     .   : milestone, 883,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7461) - mean (278ms)  : 271, 285
     .   : milestone, 278,
    master - mean (271ms)  : 267, 274
     .   : milestone, 271,

    section Baseline
    This PR (7461) - mean (277ms)  : 268, 286
     .   : milestone, 277,
    master - mean (270ms)  : 265, 276
     .   : milestone, 270,

    section CallTarget+Inlining+NGEN
    This PR (7461) - mean (815ms)  : 791, 840
     .   : milestone, 815,
    master - mean (796ms)  : 774, 818
     .   : milestone, 796,
Loading

@pr-commenter
Copy link

pr-commenter bot commented Sep 3, 2025 •
edited
Loading

Benchmarks

Benchmarks Report for benchmark platform 🐌

Benchmarks for #7461 compared to master:

  • 1 benchmarks are faster, with geometric mean 1.153
  • 1 benchmarks are slower, with geometric mean 1.152
  • 5 benchmarks have fewer allocations
  • 5 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 11.2μs 52.7ns 211ns 0 0 0 5.49 KB
master StartStopWithChild netcoreapp3.1 14.1μs 71.9ns 321ns 0 0 0 5.69 KB
master StartStopWithChild net472 22.4μs 125ns 878ns 0.966 0.322 0.107 6.01 KB
#7461 StartStopWithChild net6.0 10.3μs 54.2ns 271ns 0 0 0 5.51 KB
#7461 StartStopWithChild netcoreapp3.1 13.8μs 66.2ns 273ns 0 0 0 5.69 KB
#7461 StartStopWithChild net472 22.1μs 111ns 619ns 0.966 0.322 0.107 6.02 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 932μs 81.6ns 305ns 0 0 0 2.71 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 1.05ms 131ns 492ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 1.19ms 398ns 1.54μs 0 0 0 3.31 KB
#7461 WriteAndFlushEnrichedTraces net6.0 939μs 96.5ns 374ns 0 0 0 2.71 KB
#7461 WriteAndFlushEnrichedTraces netcoreapp3.1 1.04ms 108ns 403ns 0 0 0 2.7 KB
#7461 WriteAndFlushEnrichedTraces net472 1.2ms 352ns 1.36μs 0 0 0 3.31 KB
Benchmarks.Trace.Asm.AppSecBodyBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master AllCycleSimpleBody net6.0 324μs 1.32μs 5.11μs 0 0 0 172.08 KB
master AllCycleSimpleBody netcoreapp3.1 470μs 1.65μs 6.41μs 0 0 0 174.18 KB
master AllCycleSimpleBody net472 428μs 116ns 451ns 29.2 0 0 194.24 KB
master AllCycleMoreComplexBody net6.0 329μs 1.34μs 4.82μs 0 0 0 175.58 KB
master AllCycleMoreComplexBody netcoreapp3.1 499μs 184ns 714ns 0 0 0 177.6 KB
master AllCycleMoreComplexBody net472 432μs 83.3ns 312ns 30.2 0 0 197.76 KB
master ObjectExtractorSimpleBody net6.0 324ns 1.74ns 9.03ns 0 0 0 280 B
master ObjectExtractorSimpleBody netcoreapp3.1 401ns 2.18ns 11.9ns 0 0 0 272 B
master ObjectExtractorSimpleBody net472 299ns 0.0413ns 0.16ns 0.0437 0 0 281 B
master ObjectExtractorMoreComplexBody net6.0 6.14μs 31.9ns 146ns 0 0 0 3.78 KB
master ObjectExtractorMoreComplexBody netcoreapp3.1 7.83μs 23.5ns 87.9ns 0 0 0 3.69 KB
master ObjectExtractorMoreComplexBody net472 6.76μs 1.22ns 4.56ns 0.574 0 0 3.8 KB
#7461 AllCycleSimpleBody net6.0 323μs 1.16μs 4.5μs 0 0 0 172.07 KB
#7461 AllCycleSimpleBody netcoreapp3.1 454μs 2.17μs 8.68μs 0 0 0 174.18 KB
#7461 AllCycleSimpleBody net472 425μs 187ns 725ns 29.2 0 0 194.24 KB
#7461 AllCycleMoreComplexBody net6.0 336μs 277ns 1.03μs 0 0 0 175.58 KB
#7461 AllCycleMoreComplexBody netcoreapp3.1 484μs 991ns 3.84μs 0 0 0 177.6 KB
#7461 AllCycleMoreComplexBody net472 434μs 75.8ns 294ns 30.2 0 0 197.76 KB
#7461 ObjectExtractorSimpleBody net6.0 327ns 1.52ns 6.07ns 0 0 0 280 B
#7461 ObjectExtractorSimpleBody netcoreapp3.1 405ns 0.236ns 0.914ns 0 0 0 272 B
#7461 ObjectExtractorSimpleBody net472 303ns 0.0292ns 0.101ns 0.0437 0 0 281 B
#7461 ObjectExtractorMoreComplexBody net6.0 6.31μs 23.6ns 91.3ns 0 0 0 3.78 KB
#7461 ObjectExtractorMoreComplexBody netcoreapp3.1 7.85μs 37.1ns 148ns 0 0 0 3.69 KB
#7461 ObjectExtractorMoreComplexBody net472 6.78μs 2.4ns 9.29ns 0.574 0 0 3.8 KB
Benchmarks.Trace.Asm.AppSecEncoderBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EncodeArgs net6.0 76.8μs 239ns 924ns 0 0 0 32.4 KB
master EncodeArgs netcoreapp3.1 96.4μs 266ns 1.03μs 0 0 0 32.4 KB
master EncodeArgs net472 109μs 16.1ns 62.2ns 4.91 0 0 32.51 KB
master EncodeLegacyArgs net6.0 143μs 22.4ns 80.7ns 0 0 0 2.15 KB
master EncodeLegacyArgs netcoreapp3.1 201μs 195ns 755ns 0 0 0 2.14 KB
master EncodeLegacyArgs net472 261μs 64.8ns 251ns 0 0 0 2.16 KB
#7461 EncodeArgs net6.0 76.9μs 303ns 1.17μs 0 0 0 32.4 KB
#7461 EncodeArgs netcoreapp3.1 97.4μs 225ns 873ns 0 0 0 32.4 KB
#7461 EncodeArgs net472 110μs 16.6ns 62ns 4.94 0 0 32.51 KB
#7461 EncodeLegacyArgs net6.0 159μs 232ns 897ns 0 0 0 2.14 KB
#7461 EncodeLegacyArgs netcoreapp3.1 198μs 137ns 533ns 0 0 0 2.14 KB
#7461 EncodeLegacyArgs net472 261μs 46.3ns 179ns 0 0 0 2.16 KB
Benchmarks.Trace.Asm.AppSecWafBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunWafRealisticBenchmark net6.0 415μs 73.4ns 284ns 0 0 0 4.55 KB
master RunWafRealisticBenchmark netcoreapp3.1 415μs 383ns 1.33μs 0 0 0 4.48 KB
master RunWafRealisticBenchmark net472 431μs 87.9ns 341ns 0 0 0 4.68 KB
master RunWafRealisticBenchmarkWithAttack net6.0 291μs 56.3ns 211ns 0 0 0 2.24 KB
master RunWafRealisticBenchmarkWithAttack netcoreapp3.1 299μs 51.6ns 186ns 0 0 0 2.22 KB
master RunWafRealisticBenchmarkWithAttack net472 312μs 63.2ns 245ns 0 0 0 2.29 KB
#7461 RunWafRealisticBenchmark net6.0 399μs 265ns 1.03μs 0 0 0 4.55 KB
#7461 RunWafRealisticBenchmark netcoreapp3.1 413μs 353ns 1.27μs 0 0 0 4.48 KB
#7461 RunWafRealisticBenchmark net472 437μs 136ns 491ns 0 0 0 4.66 KB
#7461 RunWafRealisticBenchmarkWithAttack net6.0 287μs 82.2ns 307ns 0 0 0 2.24 KB
#7461 RunWafRealisticBenchmarkWithAttack netcoreapp3.1 300μs 218ns 785ns 0 0 0 2.22 KB
#7461 RunWafRealisticBenchmarkWithAttack net472 315μs 52.2ns 195ns 0 0 0 2.29 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 61.1μs 94.1ns 326ns 0 0 0 14.52 KB
master SendRequest netcoreapp3.1 70.9μs 98.4ns 355ns 0 0 0 17.42 KB
master SendRequest net472 0.00117ns 0.000797ns 0.00309ns 0 0 0 0 b
#7461 SendRequest net6.0 60.4μs 50.3ns 188ns 0 0 0 14.52 KB
#7461 SendRequest netcoreapp3.1 71.6μs 54.6ns 211ns 0 0 0 17.42 KB
#7461 SendRequest net472 0.00994ns 0.00274ns 0.0106ns 0 0 0 0 b
Benchmarks.Trace.CharSliceBenchmark - Slower ⚠️ More allocations ⚠️

Slower ⚠️ in #7461

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool‑netcoreapp3.1 1.152 797,345.02 918,665.81

More allocations ⚠️ in #7461

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice‑net472 0 b 73 B 73 B ∞
Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool‑net472 0 b 46 B 46 B ∞
Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice‑net6.0 2 B 7 B 5 B 250.00%
Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool‑net6.0 3 B 5 B 2 B 66.67%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master OriginalCharSlice net6.0 2.09ms 803ns 3μs 0 0 0 640.01 KB
master OriginalCharSlice netcoreapp3.1 2.09ms 3.63μs 14.1μs 0 0 0 640 KB
master OriginalCharSlice net472 2.59ms 256ns 957ns 100 0 0 641.95 KB
master OptimizedCharSlice net6.0 1.41ms 341ns 1.32μs 0 0 0 2 B
master OptimizedCharSlice netcoreapp3.1 1.69ms 274ns 1.06μs 0 0 0 1 B
master OptimizedCharSlice net472 2ms 471ns 1.82μs 0 0 0 0 b
master OptimizedCharSliceWithPool net6.0 832μs 31.2ns 117ns 0 0 0 3 B
master OptimizedCharSliceWithPool netcoreapp3.1 797μs 97ns 376ns 0 0 0 0 b
master OptimizedCharSliceWithPool net472 1.16ms 69.5ns 260ns 0 0 0 0 b
#7461 OriginalCharSlice net6.0 1.92ms 327ns 1.22μs 0 0 0 640.01 KB
#7461 OriginalCharSlice netcoreapp3.1 2.12ms 3μs 10.8μs 0 0 0 640 KB
#7461 OriginalCharSlice net472 2.81ms 909ns 3.4μs 100 0 0 641.95 KB
#7461 OptimizedCharSlice net6.0 1.44ms 408ns 1.58μs 0 0 0 7 B
#7461 OptimizedCharSlice netcoreapp3.1 1.65ms 751ns 2.91μs 0 0 0 1 B
#7461 OptimizedCharSlice net472 2.03ms 345ns 1.29μs 0 0 0 73 B
#7461 OptimizedCharSliceWithPool net6.0 845μs 23.3ns 90.2ns 0 0 0 5 B
#7461 OptimizedCharSliceWithPool netcoreapp3.1 919μs 40.8ns 158ns 0 0 0 0 b
#7461 OptimizedCharSliceWithPool net472 1.13ms 81.7ns 316ns 0 0 0 46 B
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Faster 🎉 More allocations ⚠️

Faster 🎉 in #7461

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net6.0 1.153 801,774.80 695,571.25

More allocations ⚠️ in #7461

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net6.0 41.61 KB 41.85 KB 237 B 0.57%

Fewer allocations 🎉 in #7461

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑netcoreapp3.1 42.11 KB 41.75 KB -359 B -0.85%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 783μs 4.59μs 44.1μs 0 0 0 41.61 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 698μs 2.36μs 9.13μs 0 0 0 42.11 KB
master WriteAndFlushEnrichedTraces net472 951μs 5.2μs 29μs 4.46 0 0 55.67 KB
#7461 WriteAndFlushEnrichedTraces net6.0 697μs 1.25μs 4.84μs 0 0 0 41.85 KB
#7461 WriteAndFlushEnrichedTraces netcoreapp3.1 758μs 4.44μs 41.2μs 0 0 0 41.75 KB
#7461 WriteAndFlushEnrichedTraces net472 970μs 4.58μs 19.4μs 4.46 0 0 55.74 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.84μs 9.1ns 38.6ns 0 0 0 1.02 KB
master ExecuteNonQuery netcoreapp3.1 2.59μs 12ns 48ns 0 0 0 1.02 KB
master ExecuteNonQuery net472 2.84μs 4.68ns 18.1ns 0.157 0.0142 0 987 B
#7461 ExecuteNonQuery net6.0 1.9μs 3.45ns 13.4ns 0 0 0 1.02 KB
#7461 ExecuteNonQuery netcoreapp3.1 2.46μs 11.5ns 47.6ns 0 0 0 1.02 KB
#7461 ExecuteNonQuery net472 2.69μs 2.94ns 11ns 0.149 0.0135 0 987 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.81μs 3.24ns 12.5ns 0 0 0 1.03 KB
master CallElasticsearch netcoreapp3.1 2.26μs 3.97ns 15.4ns 0 0 0 1.03 KB
master CallElasticsearch net472 3.51μs 3.29ns 12.7ns 0.159 0 0 1.04 KB
master CallElasticsearchAsync net6.0 1.73μs 7.66ns 29.7ns 0 0 0 1.01 KB
master CallElasticsearchAsync netcoreapp3.1 2.32μs 10.9ns 42.4ns 0 0 0 1.08 KB
master CallElasticsearchAsync net472 3.85μs 3.36ns 13ns 0.171 0 0 1.1 KB
#7461 CallElasticsearch net6.0 1.74μs 8.08ns 31.3ns 0 0 0 1.03 KB
#7461 CallElasticsearch netcoreapp3.1 2.25μs 11.1ns 47.2ns 0 0 0 1.03 KB
#7461 CallElasticsearch net472 3.62μs 7.09ns 27.5ns 0.161 0 0 1.04 KB
#7461 CallElasticsearchAsync net6.0 1.89μs 4.92ns 19ns 0 0 0 1.01 KB
#7461 CallElasticsearchAsync netcoreapp3.1 2.54μs 4.44ns 17.2ns 0 0 0 1.08 KB
#7461 CallElasticsearchAsync net472 3.75μs 3.95ns 15.3ns 0.168 0 0 1.1 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.85μs 2.49ns 9.31ns 0 0 0 952 B
master ExecuteAsync netcoreapp3.1 2.26μs 4.31ns 16.7ns 0 0 0 952 B
master ExecuteAsync net472 2.41μs 0.896ns 3.47ns 0.145 0 0 915 B
#7461 ExecuteAsync net6.0 1.83μs 2.29ns 8.88ns 0 0 0 952 B
#7461 ExecuteAsync netcoreapp3.1 2.29μs 7.03ns 27.2ns 0 0 0 952 B
#7461 ExecuteAsync net472 2.48μs 3.77ns 14.6ns 0.137 0 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 7μs 5.87ns 21.2ns 0 0 0 2.36 KB
master SendAsync netcoreapp3.1 8.48μs 24ns 92.9ns 0 0 0 2.9 KB
master SendAsync net472 12.1μs 11.7ns 43.9ns 0.486 0 0 3.18 KB
#7461 SendAsync net6.0 7.25μs 3.29ns 12.3ns 0 0 0 2.36 KB
#7461 SendAsync netcoreapp3.1 8.5μs 18.2ns 70.6ns 0 0 0 2.9 KB
#7461 SendAsync net472 12.1μs 11.7ns 45.4ns 0.48 0 0 3.18 KB
Benchmarks.Trace.Iast.StringAspectsBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7461

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑netcoreapp3.1 257.26 KB 255.49 KB -1.77 KB -0.69%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑net6.0 43.78 KB 43.14 KB -632 B -1.44%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net6.0 275.91 KB 258.86 KB -17.05 KB -6.18%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑net472 65.54 KB 57.34 KB -8.19 KB -12.50%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StringConcatBenchmark net6.0 43.8μs 231ns 1.13μs 0 0 0 43.78 KB
master StringConcatBenchmark netcoreapp3.1 53.6μs 669ns 6.42μs 0 0 0 42.84 KB
master StringConcatBenchmark net472 56.4μs 160ns 575ns 0 0 0 65.54 KB
master StringConcatAspectBenchmark net6.0 484μs 1.02μs 3.54μs 0 0 0 275.91 KB
master StringConcatAspectBenchmark netcoreapp3.1 516μs 1.57μs 5.89μs 0 0 0 257.26 KB
master StringConcatAspectBenchmark net472 406μs 2.3μs 15.2μs 0 0 0 278.53 KB
#7461 StringConcatBenchmark net6.0 46.4μs 543ns 5.15μs 0 0 0 43.14 KB
#7461 StringConcatBenchmark netcoreapp3.1 47.8μs 262ns 1.52μs 0 0 0 42.68 KB
#7461 StringConcatBenchmark net472 57.1μs 200ns 721ns 0 0 0 57.34 KB
#7461 StringConcatAspectBenchmark net6.0 536μs 2.7μs 12.1μs 0 0 0 258.86 KB
#7461 StringConcatAspectBenchmark netcoreapp3.1 492μs 1.46μs 5.47μs 0 0 0 255.49 KB
#7461 StringConcatAspectBenchmark net472 408μs 2.19μs 11.8μs 0 0 0 278.53 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.67μs 2.95ns 11.4ns 0 0 0 1.7 KB
master EnrichedLog netcoreapp3.1 3.38μs 13.2ns 51.1ns 0 0 0 1.7 KB
master EnrichedLog net472 4.03μs 4.47ns 17.3ns 0.24 0 0 1.64 KB
#7461 EnrichedLog net6.0 2.56μs 12.3ns 50.9ns 0 0 0 1.7 KB
#7461 EnrichedLog netcoreapp3.1 3.3μs 1.32ns 5.13ns 0 0 0 1.7 KB
#7461 EnrichedLog net472 4.1μs 3.6ns 14ns 0.246 0 0 1.64 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 123μs 36.6ns 137ns 0 0 0 4.31 KB
master EnrichedLog netcoreapp3.1 128μs 285ns 1.06μs 0 0 0 4.31 KB
master EnrichedLog net472 167μs 29.9ns 116ns 0 0 0 4.52 KB
#7461 EnrichedLog net6.0 123μs 48.4ns 188ns 0 0 0 4.31 KB
#7461 EnrichedLog netcoreapp3.1 129μs 208ns 807ns 0 0 0 4.31 KB
#7461 EnrichedLog net472 167μs 76.1ns 274ns 0 0 0 4.52 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 4.95μs 18.1ns 67.8ns 0 0 0 2.26 KB
master EnrichedLog netcoreapp3.1 6.85μs 24.5ns 94.7ns 0 0 0 2.26 KB
master EnrichedLog net472 7.47μs 8.45ns 32.7ns 0.299 0 0 2.08 KB
#7461 EnrichedLog net6.0 5.04μs 13.4ns 51.7ns 0 0 0 2.26 KB
#7461 EnrichedLog netcoreapp3.1 7μs 26.1ns 101ns 0 0 0 2.26 KB
#7461 EnrichedLog net472 7.52μs 5.27ns 20.4ns 0.299 0 0 2.08 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 2.06μs 9.77ns 39.1ns 0 0 0 1.2 KB
master SendReceive netcoreapp3.1 2.66μs 2.18ns 8.16ns 0 0 0 1.2 KB
master SendReceive net472 3.04μs 0.99ns 3.84ns 0.185 0 0 1.2 KB
#7461 SendReceive net6.0 1.94μs 10.4ns 52.9ns 0 0 0 1.2 KB
#7461 SendReceive netcoreapp3.1 2.55μs 9.6ns 37.2ns 0 0 0 1.2 KB
#7461 SendReceive net472 3.13μs 3.16ns 12.2ns 0.186 0 0 1.2 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 4.03μs 18.8ns 70.3ns 0 0 0 1.58 KB
master EnrichedLog netcoreapp3.1 5.76μs 5.61ns 21.7ns 0 0 0 1.63 KB
master EnrichedLog net472 6.64μs 13ns 50.3ns 0.299 0 0 2.03 KB
#7461 EnrichedLog net6.0 4.17μs 5.56ns 21.5ns 0 0 0 1.58 KB
#7461 EnrichedLog netcoreapp3.1 5.45μs 17.6ns 68.2ns 0 0 0 1.63 KB
#7461 EnrichedLog net472 6.39μs 6.04ns 23.4ns 0.319 0 0 2.03 KB
Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 734ns 3.84ns 19.2ns 0 0 0 576 B
master StartFinishSpan netcoreapp3.1 949ns 4.76ns 20.2ns 0 0 0 576 B
master StartFinishSpan net472 899ns 0.0889ns 0.333ns 0.09 0 0 578 B
master StartFinishScope net6.0 875ns 4.79ns 29.1ns 0 0 0 696 B
master StartFinishScope netcoreapp3.1 1.15μs 5.53ns 23.4ns 0 0 0 696 B
master StartFinishScope net472 1.1μs 0.348ns 1.3ns 0.0992 0 0 658 B
#7461 StartFinishSpan net6.0 753ns 3.71ns 18.2ns 0 0 0 576 B
#7461 StartFinishSpan netcoreapp3.1 938ns 4.78ns 21.4ns 0 0 0 576 B
#7461 StartFinishSpan net472 917ns 0.144ns 0.537ns 0.089 0 0 578 B
#7461 StartFinishScope net6.0 891ns 4.41ns 17.6ns 0 0 0 696 B
#7461 StartFinishScope netcoreapp3.1 1.11μs 5.26ns 21ns 0 0 0 696 B
#7461 StartFinishScope net472 1.1μs 0.37ns 1.38ns 0.0995 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 1.04μs 0.683ns 2.56ns 0 0 0 696 B
master RunOnMethodBegin netcoreapp3.1 1.36μs 6.56ns 27ns 0 0 0 696 B
master RunOnMethodBegin net472 1.39μs 1.32ns 5.1ns 0.105 0 0 658 B
#7461 RunOnMethodBegin net6.0 1.01μs 0.881ns 3.41ns 0 0 0 696 B
#7461 RunOnMethodBegin netcoreapp3.1 1.4μs 5.32ns 20.6ns 0 0 0 696 B
#7461 RunOnMethodBegin net472 1.4μs 1.83ns 7.1ns 0.0986 0 0 658 B

@daniel-romano-DD daniel-romano-DD force-pushed the dani/asm/update_private_ips branch from f19f881 to 7878c8f Compare September 3, 2025 13:02
@daniel-romano-DD daniel-romano-DD marked this pull request as ready for review September 3, 2025 13:50
@daniel-romano-DD daniel-romano-DD requested a review from a team as a code owner September 3, 2025 13:50
@daniel-romano-DD daniel-romano-DD merged commit ecca1b2 into master Sep 4, 2025
153 checks passed
@daniel-romano-DD daniel-romano-DD deleted the dani/asm/update_private_ips branch September 4, 2025 09:10
@github-actions github-actions bot added this to the vNext-v3 milestone Sep 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertpi robertpi robertpi approved these changes

@andrewlock andrewlock andrewlock approved these changes

Assignees
No one assigned
Labels
area:asm
Projects
None yet
Milestone
3.26.0
Development

Successfully merging this pull request may close these issues.
3 participants
@daniel-romano-DD @robertpi @andrewlock