Detect libdatadog available #7380
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onfig for support
Integrate everywhere and make sure nothing is logging test squash! Integrate everywhere and make sure nothing is logging
squash! Integrate everywhere and make sure nothing is logging dispose better and safer libdatadog config Improve allocation Answer to adjusting / nit comments
anna-git
force-pushed
the
anna/infering-libdatadog-availability
branch
from
72a8c2d to
24e0a4b
Compare
|
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing the following branches/commits: Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
dateFormat X
axisFormat %s
todayMarker off
section Bailout
This PR (7380) - mean (72ms) : 71, 73
. : milestone, 72,
master - mean (72ms) : 71, 73
. : milestone, 72,
section Baseline
This PR (7380) - mean (68ms) : 65, 71
. : milestone, 68,
master - mean (69ms) : 66, 71
. : milestone, 69,
section CallTarget+Inlining+NGEN
This PR (7380) - mean (1,027ms) : 1003, 1050
. : milestone, 1027,
master - mean (1,016ms) : 999, 1034
. : milestone, 1016,
gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Bailout
This PR (7380) - mean (107ms) : 106, 109
. : milestone, 107,
master - mean (108ms) : 107, 109
. : milestone, 108,
section Baseline
This PR (7380) - mean (106ms) : 104, 109
. : milestone, 106,
master - mean (107ms) : 105, 110
. : milestone, 107,
section CallTarget+Inlining+NGEN
This PR (7380) - mean (723ms) : 713, 734
. : milestone, 723,
master - mean (719ms) : 710, 727
. : milestone, 719,
gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Bailout
This PR (7380) - mean (95ms) : 94, 96
. : milestone, 95,
master - mean (95ms) : 94, 96
. : milestone, 95,
section Baseline
This PR (7380) - mean (95ms) : 93, 97
. : milestone, 95,
master - mean (95ms) : 93, 96
. : milestone, 95,
section CallTarget+Inlining+NGEN
This PR (7380) - mean (678ms) : 666, 690
. : milestone, 678,
master - mean (679ms) : 666, 691
. : milestone, 679,
gantt
title Execution time (ms) FakeDbCommand (.NET 8)
dateFormat X
axisFormat %s
todayMarker off
section Bailout
This PR (7380) - mean (94ms) : 93, 96
. : milestone, 94,
master - mean (94ms) : 93, 95
. : milestone, 94,
section Baseline
This PR (7380) - mean (93ms) : 91, 96
. : milestone, 93,
master - mean (93ms) : 91, 95
. : milestone, 93,
section CallTarget+Inlining+NGEN
This PR (7380) - mean (619ms) : 608, 630
. : milestone, 619,
master - mean (620ms) : 609, 631
. : milestone, 620,
gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
dateFormat X
axisFormat %s
todayMarker off
section Bailout
This PR (7380) - mean (206ms) : 197, 215
. : milestone, 206,
master - mean (206ms) : 194, 217
. : milestone, 206,
section Baseline
This PR (7380) - mean (207ms) : 193, 221
. : milestone, 207,
master - mean (213ms) : 198, 229
. : milestone, 213,
section CallTarget+Inlining+NGEN
This PR (7380) - mean (1,255ms) : 1200, 1311
. : milestone, 1255,
master - mean (1,223ms) : 1165, 1282
. : milestone, 1223,
gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Bailout
This PR (7380) - mean (304ms) : 277, 330
. : milestone, 304,
master - mean (296ms) : 274, 318
. : milestone, 296,
section Baseline
This PR (7380) - mean (304ms) : 281, 328
. : milestone, 304,
master - mean (291ms) : 273, 309
. : milestone, 291,
section CallTarget+Inlining+NGEN
This PR (7380) - mean (1,014ms) : 968, 1061
. : milestone, 1014,
master - mean (990ms) : 931, 1050
. : milestone, 990,
gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Bailout
This PR (7380) - mean (292ms) : 270, 313
. : milestone, 292,
master - mean (295ms) : 272, 319
. : milestone, 295,
section Baseline
This PR (7380) - mean (302ms) : 282, 321
. : milestone, 302,
master - mean (284ms) : 272, 295
. : milestone, 284,
section CallTarget+Inlining+NGEN
This PR (7380) - mean (964ms) : 914, 1015
. : milestone, 964,
master - mean (974ms) : 924, 1025
. : milestone, 974,
gantt
title Execution time (ms) HttpMessageHandler (.NET 8)
dateFormat X
axisFormat %s
todayMarker off
section Bailout
This PR (7380) - mean (302ms) : 274, 330
. : milestone, 302,
master - mean (292ms) : 269, 316
. : milestone, 292,
section Baseline
This PR (7380) - mean (296ms) : 273, 320
. : milestone, 296,
master - mean (297ms) : 279, 315
. : milestone, 297,
section CallTarget+Inlining+NGEN
This PR (7380) - mean (903ms) : 801, 1005
. : milestone, 903,
master - mean (874ms) : 801, 948
. : milestone, 874,
|
| @@ -295,6 +308,9 @@ private static class NonWindows | |||
| [DllImport("Datadog.Tracer.Native")] | |||
| public static extern bool IsProfilerAttached(); | |||
|
|
|||
| [DllImport("Datadog.Tracer.Native.")] | |||
There was a problem hiding this comment.
Suggested change
| [DllImport("Datadog.Tracer.Native.")] | |
| [DllImport("Datadog.Tracer.Native")] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Reason for change
Implementation details
Test coverage
Other details