Skip to content

Conversation

khewonc
Copy link
Contributor

@khewonc khewonc commented Aug 27, 2025

What does this PR do?

  • Adds some controller tests for DDAIs
  • When a DCA token is set in a DDA, clear the literal token in the DDAI since we create a secret for it
  • Add remote config status only when it is non-nil

Motivation

https://datadoghq.atlassian.net/browse/AGENTONB-2486

Additional Notes

Anything else we should know when reviewing?

Minimum Agent Versions

Are there minimum versions of the Datadog Agent and/or Cluster Agent required?

  • Agent: vX.Y.Z
  • Cluster Agent: vX.Y.Z

Describe your test plan

Write there any instructions and details you may have to test your PR.

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label

@khewonc khewonc requested a review from a team as a code owner August 27, 2025 19:42
@khewonc khewonc added bug Something isn't working tooling qa/skip-qa labels Aug 27, 2025
@codecov-commenter
Copy link

codecov-commenter commented Aug 27, 2025

Codecov Report

❌ Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 38.92%. Comparing base (900987e) to head (55e5420).

Files with missing lines Patch % Lines
.../controller/datadogagent/testutils/client_utils.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2139      +/-   ##
==========================================
+ Coverage   38.62%   38.92%   +0.30%     
==========================================
  Files         254      254              
  Lines       26025    26029       +4     
==========================================
+ Hits        10051    10132      +81     
+ Misses      15388    15288     -100     
- Partials      586      609      +23     
Flag Coverage Δ
unittests 38.92% <83.33%> (+0.30%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
internal/controller/datadogagent/ddai.go 67.16% <100.00%> (+6.55%) ⬆️
internal/controller/datadogagent/global/utils.go 86.20% <100.00%> (+0.49%) ⬆️
.../controller/datadogagent/testutils/client_utils.go 0.00% <0.00%> (ø)

... and 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 900987e...55e5420. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@khewonc khewonc merged commit 7e19847 into main Sep 22, 2025
30 checks passed
@khewonc khewonc deleted the khewonc/ddai-test branch September 22, 2025 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working qa/skip-qa tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants