Skip to content

Conversation

krlv
Copy link

@krlv krlv commented Jun 9, 2025

What does this PR do?

Add RBAC support for the k8sattributes processor in DDOT Collector

Motivation

Enhance RBAC Support for the k8sattributes in the Operator

Additional Notes

TBD

Minimum Agent Versions

Are there minimum versions of the Datadog Agent and/or Cluster Agent required?

  • Agent: v7.65.0
  • Cluster Agent: vX.Y.Z

Describe your test plan

TBD

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label

@krlv krlv added this to the v1.17.0 milestone Jun 9, 2025
@krlv krlv added documentation Improvements or additions to documentation enhancement New feature or request labels Jun 9, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jun 9, 2025

Codecov Report

Attention: Patch coverage is 92.59259% with 10 lines in your changes missing coverage. Please review.

Project coverage is 52.00%. Comparing base (c523677) to head (a337773).

Files with missing lines Patch % Lines
...ller/datadogagent/feature/otelcollector/feature.go 88.63% 6 Missing and 4 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1963      +/-   ##
==========================================
+ Coverage   51.85%   52.00%   +0.15%     
==========================================
  Files         327      329       +2     
  Lines       33512    33618     +106     
==========================================
+ Hits        17378    17484     +106     
  Misses      15306    15306              
  Partials      828      828              
Flag Coverage Δ
unittests 52.00% <92.59%> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ller/datadogagent/defaults/datadogagent_default.go 91.72% <100.00%> (+0.02%) ⬆️
...roller/datadogagent/feature/otelcollector/const.go 100.00% <100.00%> (ø)
...troller/datadogagent/feature/otelcollector/rbac.go 100.00% <100.00%> (ø)
pkg/testutils/builder.go 92.83% <100.00%> (+0.07%) ⬆️
...ller/datadogagent/feature/otelcollector/feature.go 87.30% <88.63%> (+2.32%) ⬆️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c523677...a337773. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@levan-m levan-m modified the milestones: v1.17.0, v1.18.0 Jul 8, 2025
@levan-m levan-m modified the milestones: v1.18.0, v1.19.0 Aug 13, 2025
@levan-m levan-m modified the milestones: v1.19.0, v1.20.0 Sep 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants