Skip to content

Fix basic auth requirements #2481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .apigentools-info
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,13 @@
"spec_versions": {
"v1": {
"apigentools_version": "1.6.6",
"regenerated": "2025-06-20 19:51:44.281546",
"spec_repo_commit": "51272749"
"regenerated": "2025-06-23 07:59:25.891159",
"spec_repo_commit": "74866a53"
},
"v2": {
"apigentools_version": "1.6.6",
"regenerated": "2025-06-20 19:51:44.297382",
"spec_repo_commit": "51272749"
"regenerated": "2025-06-23 07:59:25.906930",
"spec_repo_commit": "74866a53"
}
}
}
3 changes: 0 additions & 3 deletions .generator/schemas/v1/openapi.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14785,9 +14785,6 @@ components:
description: Username to use for the basic authentication.
example: my_username
type: string
required:
- password
- username
type: object
SyntheticsBasicAuthWebType:
default: web
Expand Down
33 changes: 2 additions & 31 deletions lib/datadog_api_client/v1/models/synthetics_basic_auth_web.rb
Original file line number Diff line number Diff line change
Expand Up @@ -22,13 +22,13 @@ class SyntheticsBasicAuthWeb
include BaseGenericModel

# Password to use for the basic authentication.
attr_reader :password
attr_accessor :password

# The type of basic authentication to use when performing the test.
attr_accessor :type

# Username to use for the basic authentication.
attr_reader :username
attr_accessor :username

attr_accessor :additional_properties

Expand Down Expand Up @@ -83,35 +83,6 @@ def initialize(attributes = {})
end
end

# Check to see if the all the properties in the model are valid
# @return true if the model is valid
# @!visibility private
def valid?
return false if @password.nil?
return false if @username.nil?
true
end

# Custom attribute writer method with validation
# @param password [Object] Object to be assigned
# @!visibility private
def password=(password)
if password.nil?
fail ArgumentError, 'invalid value for "password", password cannot be nil.'
end
@password = password
end

# Custom attribute writer method with validation
# @param username [Object] Object to be assigned
# @!visibility private
def username=(username)
if username.nil?
fail ArgumentError, 'invalid value for "username", username cannot be nil.'
end
@username = username
end

# Returns the object in the form of hash, with additionalProperties support.
# @return [Hash] Returns the object in the form of hash
# @!visibility private
Expand Down
Loading