Skip to content

add custom extent prop for geomap widget #2448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

api-clients-generation-pipeline[bot]
Copy link
Contributor

@api-clients-generation-pipeline api-clients-generation-pipeline bot requested review from a team as code owners May 30, 2025 18:07
@@ -60,6 +65,12 @@ def initialize(attributes = {})
end
}

if attributes.key?(:'custom_extent')
if (value = attributes[:'custom_extent']).is_a?(Array)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Quality Violation

Consider using Array() to ensure the type is that of an array (...read more)

The rule "Use Array() to ensure your variable is an array" is important for ensuring your code behaves as expected, regardless of the type of data it receives. It is common in Ruby to need to iterate through an array of items. However, if the variable is not an array, this can lead to unexpected behavior or errors.

The Array() method in Ruby is a Kernel method that converts its argument to an Array. If the argument is already an Array, it returns the argument. If the argument is nil, it returns an empty Array. This can be used to ensure that a variable is an array before trying to iterate over it, preventing potential errors or unexpected behavior.

By using Array(foos), you can ensure that foos is an array before you try to iterate over it with each. This prevents the need to check if foos is an array with foos.is_a?(Array) and makes your code cleaner and easier to understand.

View in Datadog  Leave us feedback  Documentation

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented May 30, 2025

Datadog Report

Branch report: datadog-api-spec/generated/3923
Commit report: 38d8fb8
Test service: datadog-api-client-ruby

✅ 0 Failed, 1032 Passed, 2133 Skipped, 2m 1.76s Total duration (1m 7.93s time saved)

@api-clients-generation-pipeline api-clients-generation-pipeline bot force-pushed the datadog-api-spec/generated/3923 branch 2 times, most recently from 83ab8af to b566c60 Compare June 6, 2025 17:06
@api-clients-generation-pipeline api-clients-generation-pipeline bot changed the title add custom extent prop for geomap widget [DEX-114] add custom extent prop for geomap widget Jun 6, 2025
@api-clients-generation-pipeline api-clients-generation-pipeline bot changed the title [DEX-114] add custom extent prop for geomap widget add custom extent prop for geomap widget Jun 18, 2025
@api-clients-generation-pipeline api-clients-generation-pipeline bot force-pushed the datadog-api-spec/generated/3923 branch from b566c60 to 8602a00 Compare June 18, 2025 19:58
@api-clients-generation-pipeline api-clients-generation-pipeline bot force-pushed the datadog-api-spec/generated/3923 branch from 8602a00 to 70124ae Compare June 20, 2025 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant