Skip to content

Conversation

@martavicentenavarro
Copy link
Contributor

@martavicentenavarro martavicentenavarro commented Oct 24, 2025

What does this PR do?

DSCVR-205

This PR improves service name detection for Erlang applications by adding heuristics to distinguish between different BEAM-based services (RabbitMQ, CouchDB, Riak, Ejabberd, etc.) that all run under the generic beam.smp process name.

Implemented heuristic:
• If the Erlang process includes a -progname flag different from erl, use its value as the service name.
• If -progname is erl, use the last component of the -home flag (e.g., /var/lib/rabbitmq → rabbitmq).
• If no valid -progname or -home is found, return "beam" as a fallback.
• Both separated (-progname erl) and concatenated (-prognameerl) flag formats are supported.

Motivation

Currently, all Erlang-based applications appear as generic beam.smp processes in service discovery, making it impossible to distinguish between critical services.

Describe how you validated your changes

Run local test. Also some unit tests have been added in erlang_test.go.

Additional Notes

@martavicentenavarro martavicentenavarro added changelog/no-changelog qa/done QA done before merge and regressions are covered by tests team/agent-discovery labels Oct 24, 2025
@github-actions github-actions bot added the medium review PR review might take time label Oct 24, 2025
@martavicentenavarro martavicentenavarro self-assigned this Oct 24, 2025
@agent-platform-auto-pr
Copy link
Contributor

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 4d2cd39

Successful checks

Info

Quality gate Delta On disk size (MiB) Delta On wire size (MiB)
agent_deb_amd64 $${-0}$$ $${677.06}$$ < $${702.15}$$ $${-0.01}$$ $${165.26}$$ < $${177.79}$$
agent_deb_amd64_fips $${-0.01}$$ $${671.57}$$ < $${696.65}$$ $${-0.02}$$ $${164.27}$$ < $${176.53}$$
agent_heroku_amd64 $${-0}$$ $${336.53}$$ < $${340.18}$$ $${+0}$$ $${89.81}$$ < $${91.08}$$
agent_msi $${0}$$ $${1013.4}$$ < $${1015.38}$$ $${0}$$ $${148.22}$$ < $${150.78}$$
agent_rpm_amd64 $${-0}$$ $${677.05}$$ < $${702.14}$$ $${-0.03}$$ $${167.46}$$ < $${180.53}$$
agent_rpm_amd64_fips $${-0.01}$$ $${671.56}$$ < $${696.64}$$ $${+0.04}$$ $${166.13}$$ < $${178.79}$$
agent_rpm_arm64 $${-0}$$ $${667.07}$$ < $${686.31}$$ $${+0.03}$$ $${153.44}$$ < $${161.22}$$
agent_rpm_arm64_fips $${-0.01}$$ $${662.6}$$ < $${681.84}$$ $${-0.01}$$ $${152.56}$$ < $${160.18}$$
agent_suse_amd64 $${-0}$$ $${677.05}$$ < $${702.14}$$ $${-0.03}$$ $${167.46}$$ < $${180.53}$$
agent_suse_amd64_fips $${-0.01}$$ $${671.56}$$ < $${696.64}$$ $${+0.04}$$ $${166.13}$$ < $${178.79}$$
agent_suse_arm64 $${-0}$$ $${667.07}$$ < $${686.31}$$ $${+0.03}$$ $${153.44}$$ < $${161.22}$$
agent_suse_arm64_fips $${-0.01}$$ $${662.6}$$ < $${681.84}$$ $${-0.01}$$ $${152.56}$$ < $${160.18}$$
docker_agent_amd64 $${-0}$$ $${747.61}$$ < $${773.59}$$ $${+0.01}$$ $${252.09}$$ < $${266.06}$$
docker_agent_arm64 $${-0}$$ $${761.57}$$ < $${781.7}$$ $${-0.01}$$ $${242.67}$$ < $${251.85}$$
docker_agent_jmx_amd64 $${-0}$$ $${938.48}$$ < $${964.45}$$ $${-0}$$ $${320.73}$$ < $${334.68}$$
docker_agent_jmx_arm64 $${-0}$$ $${941.04}$$ < $${961.17}$$ $${-0.01}$$ $${307.28}$$ < $${316.44}$$
docker_cluster_agent_amd64 $${0}$$ $${213.35}$$ < $${213.74}$$ $${+0}$$ $${72.41}$$ < $${73.14}$$
docker_cluster_agent_arm64 $${-0}$$ $${229.24}$$ < $${229.68}$$ $${+0}$$ $${68.68}$$ < $${69.41}$$
docker_cws_instrumentation_amd64 $${-0}$$ $${7.07}$$ < $${7.12}$$ $${-0}$$ $${2.95}$$ < $${3.29}$$
docker_cws_instrumentation_arm64 $${0}$$ $${6.69}$$ < $${6.92}$$ $${-0}$$ $${2.7}$$ < $${3.07}$$
docker_dogstatsd_amd64 $${0}$$ $${38.44}$$ < $${39.3}$$ $${-0}$$ $${14.84}$$ < $${15.76}$$
docker_dogstatsd_arm64 $${-0}$$ $${37.12}$$ < $${37.94}$$ $${+0}$$ $${14.29}$$ < $${14.83}$$
dogstatsd_deb_amd64 $${0}$$ $${29.66}$$ < $${30.53}$$ $${+0}$$ $${7.82}$$ < $${8.75}$$
dogstatsd_deb_arm64 $${0}$$ $${28.25}$$ < $${29.11}$$ $${+0}$$ $${6.77}$$ < $${7.71}$$
dogstatsd_rpm_amd64 $${0}$$ $${29.66}$$ < $${30.53}$$ $${+0}$$ $${7.83}$$ < $${8.76}$$
dogstatsd_suse_amd64 $${0}$$ $${29.66}$$ < $${30.53}$$ $${+0}$$ $${7.83}$$ < $${8.76}$$
iot_agent_deb_amd64 $${-0}$$ $${42.32}$$ < $${54.97}$$ $${-0}$$ $${11.04}$$ < $${14.45}$$
iot_agent_deb_arm64 $${-0}$$ $${40.11}$$ < $${51.9}$$ $${+0}$$ $${9.53}$$ < $${12.63}$$
iot_agent_deb_armhf $${-0}$$ $${40.03}$$ < $${51.84}$$ $${-0}$$ $${9.64}$$ < $${12.74}$$
iot_agent_rpm_amd64 $${-0}$$ $${42.32}$$ < $${54.97}$$ $${-0}$$ $${11.06}$$ < $${14.47}$$
iot_agent_suse_amd64 $${-0}$$ $${42.32}$$ < $${54.97}$$ $${-0}$$ $${11.06}$$ < $${14.47}$$

@cit-pr-commenter
Copy link

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: e2c96848-c49b-435e-9570-e41ea33bf618

Baseline: 4d2cd39
Comparison: 486f374
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization -10.95 [-12.10, -9.80] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_memory memory utilization +3.77 [+3.29, +4.25] 1 Logs
file_tree memory utilization +1.03 [+0.97, +1.08] 1 Logs
ddot_metrics memory utilization +0.15 [-0.01, +0.32] 1 Logs
ddot_metrics_sum_cumulative memory utilization +0.12 [-0.01, +0.25] 1 Logs
ddot_logs memory utilization +0.12 [+0.06, +0.17] 1 Logs
otlp_ingest_metrics memory utilization +0.03 [-0.09, +0.15] 1 Logs
ddot_metrics_sum_delta memory utilization +0.03 [-0.12, +0.17] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.01 [-0.25, +0.28] 1 Logs
otlp_ingest_logs memory utilization +0.01 [-0.12, +0.14] 1 Logs
file_to_blackhole_1000ms_latency egress throughput +0.01 [-0.60, +0.61] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.01, +0.01] 1 Logs
file_to_blackhole_500ms_latency egress throughput -0.00 [-0.61, +0.60] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.03 [-0.64, +0.57] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.04 [-0.65, +0.56] 1 Logs
quality_gate_idle_all_features memory utilization -0.24 [-0.28, -0.19] 1 Logs bounds checks dashboard
ddot_metrics_sum_cumulativetodelta_exporter memory utilization -0.40 [-0.59, -0.20] 1 Logs
uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization -0.46 [-0.50, -0.42] 1 Logs
quality_gate_idle memory utilization -0.50 [-0.53, -0.46] 1 Logs bounds checks dashboard
tcp_syslog_to_blackhole ingress throughput -0.57 [-0.65, -0.48] 1 Logs
quality_gate_metrics_logs memory utilization -0.59 [-0.79, -0.40] 1 Logs bounds checks dashboard
quality_gate_logs % cpu utilization -1.86 [-4.61, +0.90] 1 Logs bounds checks dashboard
docker_containers_cpu % cpu utilization -10.95 [-12.10, -9.80] 1 Logs

Bounds Checks: ❌ Failed

perf experiment bounds_check_name replicates_passed links
docker_containers_cpu simple_check_run 10/10
docker_containers_memory memory_usage 8/10
docker_containers_memory simple_check_run 10/10
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_logs memory_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 bounds checks dashboard
quality_gate_metrics_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@martavicentenavarro martavicentenavarro marked this pull request as ready for review October 27, 2025 10:13
@martavicentenavarro martavicentenavarro requested a review from a team as a code owner October 27, 2025 10:13
@martavicentenavarro martavicentenavarro added the ask-review Ask required teams to review this PR label Oct 27, 2025
Copy link
Member

@Yumasi Yumasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@martavicentenavarro
Copy link
Contributor Author

/merge

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Oct 27, 2025

View all feedbacks in Devflow UI.

2025-10-27 10:47:06 UTC ℹ️ Start processing command /merge


2025-10-27 10:47:11 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 41m (p90).


2025-10-27 11:00:58 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit f3b6296 into main Oct 27, 2025
313 checks passed
@dd-mergequeue dd-mergequeue bot deleted the martavicentenavarro/add-erlang-service-name-heuristics branch October 27, 2025 11:00
@github-actions github-actions bot added this to the 7.73.0 milestone Oct 27, 2025
@martavicentenavarro martavicentenavarro changed the title Add heuristics for Erlang application name generation usm - Add heuristics for Erlang application name generation Oct 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ask-review Ask required teams to review this PR changelog/no-changelog medium review PR review might take time qa/done QA done before merge and regressions are covered by tests team/agent-discovery

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants