[stable/redis-ha]: Add missing keys to values.yaml #338
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added podAnnotations: {} for Redis pod annotations
- Added tolerations: [] for pod assignment tolerations
- These values were referenced in templates but not defined in values.yaml
Signed-off-by: Jeff Youngs <[email protected]>
jyoungs
commented
Aug 15, 2025
| @@ -90,7 +90,7 @@ The following table lists the configurable parameters of the Redis chart and the | |||
| | `imagePullSecrets` | Reference to one or more secrets to be used when pulling redis images | list | `[]` | | |||
There was a problem hiding this comment.
This file was generated with helm-docs (1.14.2)
|
Just keeping this alive ✌️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR fixes missing value definitions in the redis-ha chart's values.yaml file.
The chart templates reference
.Values.podAnnotationsand.Values.tolerations, but these values were not defined in values.yaml, making them opaque to chart users.Impact:
Which issue this PR fixes
Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[stable/mychartname])