Install php-compatibility in our own container to handle the dependen… #231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickygerritsen
approved these changes
Dec 2, 2025
Member
|
Is this for the codesniffer test or for something else? |
Member
Author
One of those tests yes, but I first need the image before I can test that it all works. |
For [phpcs_compatibility](https://github.com/DOMjudge/domjudge/blob/main/.github/workflows/codestyle.yml). We used another container for simplicity of maintainance, then we needed to hotpatch the container for PHP84 for the `$this` & `enums`. The plan was to do this while waiting for version 10 of the tool. Since then we've had to patch the container more and more so the "lower" maintenance cost are now in installing the tool on it's own.
vmcj
force-pushed
the
composer_php-compatibility
branch
from
e64d954 to
08698eb
Compare
Member
Author
|
@meisterT I've tried to clarify this more in the commit message. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…cies
We used another container for simplicity of maintainance, as we need to wait for version 10 and we've been for some months now it's easier to put the maintainance in our own container.