Remove LIBSPDM_MAX_CERT_CHAIN_BLOCK_LEN #3412
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyao1
reviewed
Dec 5, 2025
jyao1
reviewed
Dec 5, 2025
jyao1
reviewed
Dec 5, 2025
Member
|
See the definition in SPDM specification:
Any mismatch violates the spec. |
Li-Aaron
force-pushed
the
fix-1655
branch
3 times, most recently
from
c6ed609 to
2f230a2
Compare
fix DMTF#1655 Signed-off-by: Aaron Li <[email protected]>
steven-bellock
requested changes
Dec 5, 2025
| uint32_t req_msg_header_size; | ||
| uint32_t rsp_msg_header_size; | ||
| size_t cert_chain_size; | ||
| uint32_t max_cert_chain_block_size; |
Contributor
There was a problem hiding this comment.
Can move this declaration to line 127.
Member
There was a problem hiding this comment.
Why do we have to move?
I think nothing wrong to define it here.
| uint32_t req_msg_header_size; | ||
| uint32_t rsp_msg_header_size; | ||
| size_t cert_chain_size; | ||
| uint32_t max_cert_chain_block_size; |
Contributor
There was a problem hiding this comment.
Can move this declaration to line 166.
Member
There was a problem hiding this comment.
Why do we have to move?
I think nothing wrong to define it here.
Signed-off-by: Aaron Li <[email protected]>
This was referenced Dec 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1655