Skip to content

Conversation

tokenicrat
Copy link

The timer function del_timer_sync() was renamed to timer_delete_sync() in November 2022 (https://lkml.org/lkml/2022/11/23/1482), and a wrapper for it was recently removed. This prevents DIGImend from compiling on Linux 6.15.0 and later.

The issue can be solved by just replacing the name. Validated on Arch Linux (Linux 6.15.2).

@Eason0729
Copy link

I thinks a better approach would be using #if LINUX_VERSION_CODE >= KERNEL_VERSION(6,15,0), which enable compilation before the rename

#if LINUX_VERSION_CODE >= KERNEL_VERSION(6,15,0)
#define del_timer_sync timer_delete_sync
#endif

@tokenicrat
Copy link
Author

I thinks a better approach would be using #if LINUX_VERSION_CODE >= KERNEL_VERSION(6,15,0), which enable compilation before the rename

#if LINUX_VERSION_CODE >= KERNEL_VERSION(6,15,0)
#define del_timer_sync timer_delete_sync
#endif

Definitely it's safer, but as all mainstream desktop Linux distributions (including Ubuntu, Fedora, Debian, Arch Linux, etc.) under maintenance are shipped with Linux 6.x.y, I think it's okay to use the new name only.

@kenhys
Copy link
Contributor

kenhys commented Aug 20, 2025

Accurately, it should be because timer_delete_sync was introduced since 6.1.84:

#if LINUX_VERSION_CODE >= KERNEL_VERSION(6, 1, 84)
#define del_timer_sync timer_delete_sync
#endif

By the way, it seems that DIGImend kernel drivers try to support older kernel (I don't know whether that is actually still buildable or not) - see such as README.md , hid-uclogic-core.c, hid-uclogic-params.c.
Shouldn't we respect it?

@ruffianlabs
Copy link

as tokenicrat said, I tried & replaced the file /usr/src/digimend-13/hid-uclogic-core.c and, made the renaming from :
del_timer_sync(&drvdata->inrange_timer); TO timer_delete_sync(&drvdata->inrange_timer);

and, updated the linux & linux-headers. and, it worked. No errors.

My setup : Endeavour OS (Linux 6.16.8-arch3-1 & nvidia/580.82.09 | DE: KDE Plasma 6.4.5 | WM: KWin (Wayland))

Thank you tokenicrat & everyone who worked on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants