Support for modded honey in ban-cooking #1497
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of only banning honey from vanilla honey bees, support banning honey added by modded creatures as well.
ab9rf
approved these changes
Aug 24, 2025
SilasD
reviewed
Aug 31, 2025
There was a problem hiding this comment.
This works; there's nothing wrong with it.
But I would argue that the entire funcs.honey shouldn't really exist. Instead, this code should be folded into funcs.brew.
funcs.brew searches for materials that have a reaction product that is alcohol. And that's what this code does. The only difference here is iterating over creatures instead of plants.
Separating the code just means that anybody who is trying to ban-cooking of brewables needs to ban two categories instead one.
(Combining the two would also make it easier to refactor out the copy-paste code.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch allows ban-cooking to ban honey/brewable materials added by creatures other than honey bees. This includes vanilla bumblebees, though their honey is not currently obtainable in vanilla. However, there are mods that make bumblebees hiveable, as well as adding other types of hiveable bees.