Issue#32 #41
Open
Issue#32 #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulmueller
reviewed
May 20, 2025
| @@ -82,6 +84,27 @@ def __init__(self, | |||
| Whether to set logging level to "DEBUG" and | |||
| use threads instead of processes | |||
| """ | |||
|
|
|||
| def run(self): | |||
There was a problem hiding this comment.
What is this doing here? @Orange99
paulmueller
reviewed
May 20, 2025
|
|
||
|
|
||
| class EventStash: | ||
| def __init__(self, | ||
| index_offset: int, | ||
| feat_nevents: List[int]): | ||
| """Sort events into predefined arrays for bulk access | ||
| """Sorts events into predefined arrays for bulk access. |
There was a problem hiding this comment.
The original doc-string was better. Always use imperative language. Don't append a dot. @Orange99
paulmueller
reviewed
May 20, 2025
| @@ -194,7 +182,118 @@ def run(self): | |||
|
|
|||
| if len(cur_nevents) == 0: | |||
| self.logger.info( | |||
| "Reached dataset end (frame " | |||
| # Reached dataset end (frame | |||
There was a problem hiding this comment.
This line was part of the log message.
paulmueller
reviewed
May 20, 2025
| """ | ||
| self.events = {} | ||
| """Dictionary containing the event arrays""" |
There was a problem hiding this comment.
Don't remove existing doc strings!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.