Add missing awaits #63
Open
+44
−46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dudeplayz
force-pushed
the
add-missing-awaits
branch
from
353a358 to
2fd7ed1
Compare
Dudeplayz
force-pushed
the
add-missing-awaits
branch
from
2fd7ed1 to
476b43e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some promises are not waited for or not propagated properly. The async functionality should always be considered to be propagated to the top level caller code, which should decide if a throw is ok. Otherwise the drop should be commented, to make clear, why it is not necessary to wait for.
Perhaps related to #53 and #54, because a missing await can create race conditions.
It should be checked, if the awaits and asyncs I added are correct.
Should
executeQueue()inWebRTCPeerConnectionjust error handled inhandleSignalingMessage()or be awaited, becausehandlingSignalingMessageis by interface type declared as async. If I understand the code correctly, the queue processing should be started async, that's why it is not awaited. Otherwise the calling code, which runs in the processing loop is "blocked", until all event's are executed. Question is, if it would make a difference, if it is waited for?Also fixed some typos.