Skip to content

Fix: edit message doesn't update message queue #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 3, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 22 additions & 9 deletions discord/ext/test/backend.py
Original file line number Diff line number Diff line change
Expand Up @@ -221,15 +221,7 @@ async def edit_message(self, channel_id: int, message_id: int, **fields: dhttp.M

await callbacks.dispatch_event("edit_message", message.channel, message, fields)

out = facts.dict_from_message(message)
payload = fields.get("params").payload
# TODO : do something for files and stuff.
# if params.files:
# return self.request(r, files=params.files, form=params.multipart)
# else:
# return self.request(r, json=params.payload)
out.update(payload)
return out
return edit_message(message, **fields)

async def add_reaction(self, channel_id: int, message_id: int, emoji: str) -> None:
locs = _get_higher_locs(1)
Expand Down Expand Up @@ -853,6 +845,27 @@ def make_message(
return state._get_message(data["id"])


def edit_message(
message: discord.Message, **fields: dhttp.MultipartParameters
) -> _types.JsonDict:
data = facts.dict_from_message(message)
payload = fields.get("params").payload
# TODO : do something for files and stuff.
# if params.files:
# return self.request(r, files=params.files, form=params.multipart)
# else:
# return self.request(r, json=params.payload)
data.update(payload)

i = 0
while i < len(_cur_config.messages[message.channel.id]):
if _cur_config.messages[message.channel.id][i].get("id") == data.get("id"):
_cur_config.messages[message.channel.id][i] = data
i += 1

return data


MEMBER_MENTION: typing.Pattern = re.compile(r"<@!?[0-9]{17,21}>", re.MULTILINE)
ROLE_MENTION: typing.Pattern = re.compile(r"<@&([0-9]{17,21})>", re.MULTILINE)
CHANNEL_MENTION: typing.Pattern = re.compile(r"<#[0-9]{17,21}>", re.MULTILINE)
Expand Down
4 changes: 4 additions & 0 deletions tests/test_edit.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,10 @@ async def test_edit(bot):
channel = guild.channels[0]

mes = await channel.send("Test Message")
persisted_mes1 = await channel.fetch_message(mes.id)
edited_mes = await mes.edit(content="New Message")
persisted_mes2 = await channel.fetch_message(mes.id)

assert edited_mes.content == "New Message"
assert persisted_mes1.content == "Test Message"
assert persisted_mes2.content == "New Message"