Implemented PVE Token Access #43
Conversation
There was a problem hiding this comment.
This PR looks reasonably OK, it's a great start... I've suggested a few things I'd like looked at before I'd feel comfortable with a merge.
Also I don't have a Proxmox instance around to test this works (and we don't have any test coverage in this repo, I'd kind of love some tbh but don't have the cycles to add any + a Proxmox API mock of some sort)... @danhunsaker do you have a Proxmox instance around to test this works as intended at all...?
I sent you an E-Mail RE: PVE Instance |
|
Unfortunately, my servers were all stolen, and I haven't been able to replace them yet. I'll see about spinning a couple up in a cloud somewhere, though! |
|
Any Update? I can provide Instances to test against if you want. |
|
@danhunsaker - I can provide servers for you to test against - just lmk. |
|
ive create a pull request for a updated and backward compatible version of this class |
I've implemented token login for the API. It's transparent and either username & password an api id and token work.
I'd really like to see this implemented, so if you see any issues, please give feedback so I can fix.