[WIP] [Experimental] new architecture

[kanwarujjaval]

No description provided.

[Copilot]

Pull Request Overview

This PR implements experimental architectural changes across multiple modules and improves error handling and code clarity. Key changes include updating the database connection call in pluginManager.js, adding a fallback for performance.now() in log.js, fixing a typographical error in changeStreamReader.js, and enhancing optional chaining in ingestor.js.

Reviewed Changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.

File	Description
plugins/pluginManager.js	Updates the dbConnection invocation method
api/utils/log.js	Adds a fallback function for performance.now()
api/parts/data/changeStreamReader.js	Fixes a spelling typo in the onData parameter comment
api/ingestor.js	Enhances optional chaining with default values

Files not reviewed (1)

• .eslintrc.json: Language not supported

Comments suppressed due to low confidence (1)

plugins/pluginManager.js:1841

• The new arrow function reverses the parameter order for dbConnection compared to the original bind call. Please verify that the intended argument order is preserved to avoid unintended behavior.

databases = await Promise.all(dbs.map((db) => this.dbConnection(db, return_original)));

[Copilot]

Pull Request Overview

This PR updates the architecture by removing the extra “dont-enclose” parameter from all require calls and adapting code to changes in API responses (e.g. findOneAndUpdate now returning a .value field).

• Removes the extra parameter across multiple modules to simplify module loading
• Adjusts handling of findOneAndUpdate responses in app user and similar modules
• Employs optional chaining for configuration object access in the ingestor module

Reviewed Changes

Copilot reviewed 22 out of 24 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
plugins/locale/frontend/app.js	Removed "dont-enclose" argument from require call for countlyConfig
plugins/enterpriseinfo/frontend/app.js	Updated require of countlyConfig by removing the extra parameter
plugins/dashboards/frontend/app.js	Removed "dont-enclose" argument for consistency
plugins/crashes/frontend/app.js	Removed the extra parameter from countlyConfig import
frontend/express/public/javascripts/countly/countly.config.sample.js	Added new property INGESTOR_URL configuration
frontend/express/libs/members.js	Removed "dont-enclose" from require call for configs
frontend/express/app.js	Updated countlyConfig import by removing extra parameter
api/utils/utils.js	Removed extra parameter on countlyConfig require call
api/parts/mgmt/app_users.js	Updated result extraction from findOneAndUpdate to use .value.seq
api/parts/jobs/index.js	Removed unnecessary parameter from countlyConfig require call
api/parts/data/changeStreamReader.js	Fixed a typo in a comment and removed extra require parameter
api/ingestor.js	Removed extra parameter; added optional chaining for configuration access
api/api.js	Removed extra parameter from countlyConfig require call
api/aggregator.js	Removed extra parameter from countlyConfig require call

Files not reviewed (2)

• .eslintrc.json: Language not supported
• package.json: Language not supported