Skip to content

BJS2-76950 #3102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: kraken-master-stream10
Choose a base branch
from
Open

BJS2-76950 #3102

wants to merge 2 commits into from

Conversation

SlavaVermillion
Copy link

No description provided.

VladimirEkgardt
VladimirEkgardt reviewed May 29, 2025
View reviewed changes
Copy link

@VladimirEkgardt VladimirEkgardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Написал замечание для одного фильтра, но по сути можно ко всем отнести. А так супер)

src/test/java/school/faang/user_service/service/Service/SubscriptionServiceTest.java
public void testFollowUser_FollowsSelf() {
long userId = 1;

DataValidationException exception = assertThrows(DataValidationException.class, () -> {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

А зачем так сложно? Достаточно же просто assertThrow вызвать

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Для того чтобы проверить текст сообщения об ошибке

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VladimirEkgardt VladimirEkgardt VladimirEkgardt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SlavaVermillion @VladimirEkgardt