-
Notifications
You must be signed in to change notification settings - Fork 108
feat: Add Widget, dropdown menu with autocomplete from predefined list #3442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Widget, dropdown menu with autocomplete from predefined list #3442
Conversation
@flef , not entirely clear to me how this is supposed to work. |
Yes, the predefined values to write into the PV are hard-coded into the widget, similar to a dropdown menu. I do not need to dynamically populate the possible values from another PV. This widget functions like a dropdown menu but is not limited to 100 predefined values. Therefore, an auto-complete feature is needed to find the correct predefined value among a large set of possibilities. |
But how are the choices set in the widget editor? |
...a/org/csstudio/display/builder/representation/javafx/widgets/AutoCompleteRepresentation.java
Outdated
Show resolved
Hide resolved
I have a usability concern: This raises the question: should values other than those offered in the list be accepted? It would also be of value to add an example (or extend existing) in the |
Yes, actually, we want to allow the user to add custom input. This works more like a suggestion list rather than a real constraint. However, it may be interesting to add a property to forbid users from typing a string that is not in the suggestion list. |
I'll push example. |
Thanks, but I still find it a bit confusing that pressing the <ENTER> key when typing a value present in the list does not write to PV. |
@flef, we feel there is overlap between this widget and existing widgets. Consequently we would like to discuss use case and details in next developer meeting. If you send me your email address (to [email protected]) I will make sure to invite you. |
…feature/widget-autocomplete
…sc.tasfr.thales:7999/bgng_airmaster/phoebus into feature/widget-autocomplete # Conflicts: # app/display/representation-javafx/src/main/java/org/csstudio/display/builder/representation/javafx/widgets/AutoCompleteRepresentation.java
c16b452
to
cc9db89
Compare
Thanks florian |
I like that idea! What are the remaining differences? Combo: Enter list of "Items" or select "Items from PV" New widget: "Autocomplete Item" contains "Option1\nOption2\nOption3" The combo approach seems better for the typical use cases: Get options from PV, fall back to a handful of "Items". |
Sure. We also have a much larger topic that we want to integrate. We have made significant progress on supporting our database InfluxDB. InfluxDB is an open-source time series database designed to efficiently store and query large volumes of time-stamped data, such as monitoring metrics, events, and real-time analytics. It is optimized for high write and query performance, making it a popular choice for industrial applications and data monitoring solutions. In another related branch, we have also integrated ChartFx from fair-acc, as we have already discussed in this thread. We will share this work here as soon as we have been able to test the solution on our installations to a minimum extent. |
As for InfluxDB, we had been working on support for that, see presentation under http://www.rri.kyoto-u.ac.jp/EPICS/program.html It was faster than an RDB, but we eventually decided to not use it because
Also, the two options we have are pretty good: RDB for those who prefer generality, Archive Appliance for those who prefer something optimized for control system data. |
Thank you for the information, I am interested in the branch that supports InfluxDB. I wasn’t aware of this rounding issue. That is indeed unfortunate. I will check if this bug is still present in InfluxDB versions 2 and 3. |
I confirm that the rounding issue originates from the Java client and not from the database itself, at least in InfluxDB 2.x. The value is correctly stored into DB. |
That might be a very good fit for influx.
Good. Worst case, you could use a patched java client lib |
@kasemir @georgweiss , can one of you send me an invitation for the meeting please ? |
meet.google.com/ztf-udpr-xra<https://meet.google.com/ztf-udpr-xra?hs=224>
From: flef ***@***.***>
Reply to: ControlSystemStudio/phoebus ***@***.***>
Date: Thursday, 14 August 2025 at 13:04
To: ControlSystemStudio/phoebus ***@***.***>
Cc: Georg Weiss ***@***.***>, Mention ***@***.***>
Subject: Re: [ControlSystemStudio/phoebus] feat: Add Widget, dropdown menu with autocomplete from predefined list (PR #3442)
[Image removed by sender.]flef left a comment (ControlSystemStudio/phoebus#3442)<#3442 (comment)>
@kasemir<https://github.com/kasemir> @georgweiss<https://github.com/georgweiss> , can one of you send me an invitation for the meeting please ?
—
Reply to this email directly, view it on GitHub<#3442 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AIPUEEGUQ7XARQQ2Z3TFNBD3NRUMRAVCNFSM6AAAAAB746LXFSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTCOBYGA2DMMJZGM>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
…sc.tasfr.thales:7999/bgng_airmaster/phoebus into feature/widget-autocomplete
Hi,
I propose a new widget, it's basically a Dropdown menu from predefined list of choices, as the existing one but with autocomplete.
The list is not limited to 100 items.
Regards,
Florian.