Skip to content

Conversation

@alperhi
Copy link

@alperhi alperhi commented Nov 14, 2018

No description provided.

Copy link
Contributor

@Henning-Schulz Henning-Schulz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I get it correctly, these files should be removed:

  • continuity.forecast/telescope-multi/R/.RData
  • continuity.forecast/telescope-multi/R/.Rhistory

Copy link
Contributor

@Henning-Schulz Henning-Schulz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess also all the files in continuity.forecast/telescope-multi/R/logs/ should be removed.

Copy link
Contributor

@Henning-Schulz Henning-Schulz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks almost good, but there are some minor flaws which should be corrected.

compile project(':continuity.api')
compile project(':continuity.commons')

compile files('lib/behaviormodelextractor_forecast.jar')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should upload this to the Nexus as a new version

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 I also need this for my workload modularization approach

- --eureka.uri=http://eureka:8761/eureka

forecast:
image: continuityproject/session-logs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it be continuityproject/forecast?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ups true :)

@tobiangerstein
Copy link
Contributor

@Henning-Schulz, could you please wait to integrate this. I'll create a pull request which consists of CONT-93 and CONT-126.

@tobiangerstein
Copy link
Contributor

tobiangerstein commented Nov 16, 2018

@alperhi You can close this pull request now, since is already pushed with #91

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants