Skip to content

Conversation

@mehdi-aouadi
Copy link
Contributor

@mehdi-aouadi mehdi-aouadi commented Dec 2, 2025

PR Description

Add Gloas execution_payload_bid gossip rules

Fixed Issue(s)

#10175

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

Note

Implements Gloas execution payload bid gossip validation, wires it into the node, and adds supporting helpers, constants, tests, and fixtures.

  • Gloas Execution Payload Bid Gossip:
    • Add ExecutionPayloadBidGossipValidator with full bid validation (payment=0, dedupe, highest-value tracking, slot/current-next, known parent block/hash, active/unslashed builder with builder-withdrawal credential, balance checks, signature verification) using LRU/cache (SEEN_EXECUTION_PAYLOAD_BID_SET_SIZE, HIGHEST_BID_SET_SIZE).
    • Integrate into DefaultExecutionPayloadBidManager (constructor, validateAndAddBid) and wire via BeaconChainController.initExecutionPayloadBidManager.
  • Helpers/Config:
    • Extend GossipValidationHelper (generic index signature check, isSlotCurrentOrNext, builder index/credential/balance checks, block-hash known, time-window tweak).
    • Expose hasBuilderWithdrawalCredential via MiscHelpersGloas.
    • Add constants in spec/config/Constants.java for bid caches.
  • Test Utilities:
    • Expand DataStructureUtil bid generators (parameterized ExecutionPayloadBid/SignedExecutionPayloadBid).
  • Tests:
    • New ExecutionPayloadBidGossipValidatorTest; update DefaultExecutionPayloadBidManagerTest (new ctor); refine GossipValidationHelperTest; update LocalSignerTest expected bid signature.
  • Fixtures:
    • Update newBlockGLOAS.json fixtures (REST and validator) signed_execution_payload_bid fields.

Written by Cursor Bugbot for commit e9375c2. This will update automatically on new commits. Configure here.

@mehdi-aouadi mehdi-aouadi self-assigned this Dec 2, 2025
@mehdi-aouadi mehdi-aouadi force-pushed the 10175-execution-payload-bid-gloas-gossip branch from 44d6922 to c590df1 Compare December 3, 2025 14:31
@mehdi-aouadi mehdi-aouadi force-pushed the 10175-execution-payload-bid-gloas-gossip branch from 2d10e2d to f006907 Compare December 4, 2025 10:10
@mehdi-aouadi mehdi-aouadi marked this pull request as draft December 4, 2025 17:31
@mehdi-aouadi mehdi-aouadi marked this pull request as ready for review December 4, 2025 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant