-
Notifications
You must be signed in to change notification settings - Fork 357
Add Single block provider for Fulu #10169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
gfukushima
wants to merge
41
commits into
Consensys:master
Choose a base branch
from
gfukushima:SingleBlockProviderFulu
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gabriel Fukushima <[email protected]>
Signed-off-by: Gabriel Fukushima <[email protected]>
Signed-off-by: Gabriel Fukushima <[email protected]>
…ngleBlockProviderFulu
Signed-off-by: Gabriel Fukushima <[email protected]>
Signed-off-by: Gabriel Fukushima <[email protected]>
Signed-off-by: Gabriel Fukushima <[email protected]>
Signed-off-by: Gabriel Fukushima <[email protected]>
…ngleBlockProviderFulu
Signed-off-by: Gabriel Fukushima <[email protected]>
…new tracker due to the introduction of size limitation Signed-off-by: Gabriel Fukushima <[email protected]>
Signed-off-by: Gabriel Fukushima <[email protected]>
Signed-off-by: Gabriel Fukushima <[email protected]>
...etransition/src/main/java/tech/pegasys/teku/statetransition/datacolumns/DasSamplerBasic.java
Outdated
Show resolved
Hide resolved
...etransition/src/main/java/tech/pegasys/teku/statetransition/datacolumns/DasSamplerBasic.java
Show resolved
Hide resolved
.../beaconchain/src/main/java/tech/pegasys/teku/services/beaconchain/BeaconChainController.java
Outdated
Show resolved
Hide resolved
...etransition/src/main/java/tech/pegasys/teku/statetransition/datacolumns/DasSamplerBasic.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Gabriel Fukushima <[email protected]>
c997edc to
83730a8
Compare
Signed-off-by: Gabriel Fukushima <[email protected]>
...etransition/src/main/java/tech/pegasys/teku/statetransition/datacolumns/DasSamplerBasic.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Gabriel Fukushima <[email protected]>
Signed-off-by: Gabriel Fukushima <[email protected]>
…e fulu Signed-off-by: Gabriel Fukushima <[email protected]>
Signed-off-by: Gabriel Fukushima <[email protected]>
...nchain/src/main/java/tech/pegasys/teku/services/beaconchain/SingleBlockProviderResolver.java
Outdated
Show resolved
Hide resolved
...etransition/src/main/java/tech/pegasys/teku/statetransition/datacolumns/DasSamplerBasic.java
Outdated
Show resolved
Hide resolved
...etransition/src/main/java/tech/pegasys/teku/statetransition/datacolumns/DasSamplerBasic.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Gabriel Fukushima <[email protected]>
...etransition/src/main/java/tech/pegasys/teku/statetransition/datacolumns/DasSamplerBasic.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Gabriel Fukushima <[email protected]>
Signed-off-by: Gabriel Fukushima <[email protected]>
...etransition/src/main/java/tech/pegasys/teku/statetransition/datacolumns/DasSamplerBasic.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Gabriel Fukushima <[email protected]>
Signed-off-by: Gabriel Fukushima <[email protected]>
Signed-off-by: Gabriel Fukushima <[email protected]>
...nchain/src/main/java/tech/pegasys/teku/services/beaconchain/SingleBlockProviderResolver.java
Outdated
Show resolved
Hide resolved
...etransition/src/main/java/tech/pegasys/teku/statetransition/datacolumns/DasSamplerBasic.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Gabriel Fukushima <[email protected]>
Signed-off-by: Gabriel Fukushima <[email protected]>
Signed-off-by: Gabriel Fukushima <[email protected]>
...nsition/src/main/java/tech/pegasys/teku/statetransition/datacolumns/DasSamplerBasicImpl.java
Show resolved
Hide resolved
...nsition/src/main/java/tech/pegasys/teku/statetransition/datacolumns/DasSamplerBasicImpl.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Gabriel Fukushima <[email protected]>
Signed-off-by: Gabriel Fukushima <[email protected]>
...in/src/test/java/tech/pegasys/teku/services/beaconchain/SingleBlockProviderResolverTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Gabriel Fukushima <[email protected]>
Signed-off-by: Gabriel Fukushima <[email protected]>
.../beaconchain/src/main/java/tech/pegasys/teku/services/beaconchain/BeaconChainController.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Gabriel Fukushima <[email protected]>
...nsition/src/main/java/tech/pegasys/teku/statetransition/datacolumns/DasSamplerBasicImpl.java
Show resolved
Hide resolved
tbenr
reviewed
Dec 3, 2025
Contributor
tbenr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the direction is actually what I was having in mind. sorry for the lag
Signed-off-by: Gabriel Fukushima <[email protected]>
Signed-off-by: Gabriel Fukushima <[email protected]>
# Conflicts: # ethereum/statetransition/src/main/java/tech/pegasys/teku/statetransition/datacolumns/DasSamplerBasic.java # ethereum/statetransition/src/test/java/tech/pegasys/teku/statetransition/datacolumns/DasSamplerBasicImplTest.java
Signed-off-by: Gabriel Fukushima <[email protected]>
Signed-off-by: Gabriel Fukushima <[email protected]>
| } | ||
|
|
||
| @Override | ||
| public Map<Bytes32, DataColumnSamplingTracker> getRecentlySampledColumnsByRoot() { |
Check notice
Code scanning / CodeQL
Exposing internal representation Note
getRecentlySampledColumnsByRoot exposes the internal representation stored in field recentlySampledColumnsByRoot. The value may be modified .
getRecentlySampledColumnsByRoot exposes the internal representation stored in field recentlySampledColumnsByRoot. The value may be modified .
getRecentlySampledColumnsByRoot exposes the internal representation stored in field recentlySampledColumnsByRoot. The value may be modified .
getRecentlySampledColumnsByRoot exposes the internal representation stored in field recentlySampledColumnsByRoot. The value may be modified .
after this call to getRecentlySampledColumnsByRoot
Error loading related location
Loading getRecentlySampledColumnsByRoot exposes the internal representation stored in field recentlySampledColumnsByRoot. The value may be modified
after this call to getRecentlySampledColumnsByRoot
Error loading related location
Loading getRecentlySampledColumnsByRoot exposes the internal representation stored in field recentlySampledColumnsByRoot. The value may be modified
after this call to getRecentlySampledColumnsByRoot
Error loading related location
Loading getRecentlySampledColumnsByRoot exposes the internal representation stored in field recentlySampledColumnsByRoot. The value may be modified
after this call to getRecentlySampledColumnsByRoot
Error loading related location
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This PR add a SingleBlockProviderResolver that will return recent blocks from the tracker from FULU (DASBasicSampler) or previous forks (BlockBlobSidecarsTrackersPoolImpl)
Fixed Issue(s)
Part of #10101
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog
Note
Adds a resolver to fetch recent blocks from the DAS sampler (FULU) or blob tracker, and refactors DAS sampler into an interface with a new implementation and APIs, integrating across sync, fork choice, and tests.
DasSamplerBasicinto interface and newDasSamplerBasicImpl; add metrics and bounded in-memory tracking.DataAvailabilitySampler.checkDataAvailabilityto acceptSignedBeaconBlock; addcontainsBlock/getBlocktoDasSamplerBasic.DasPreSamplerandDataColumnSidecarAvailabilityCheckerto new API.DasSamplerBasicImpl.SingleBlockProviderResolverto fetch blocks fromDasSamplerBasicfirst, thenBlockBlobSidecarsTrackersPool; wire intoBeaconChainControllerforStorageBackedRecentChainData.RecentBlocksFetchServicenow depends onDasSamplerBasicand skips fetching when sampler already has the block; propagate viaDefaultSyncServiceFactoryand test fixtures.BeaconChainControllerinitializes and exposesdasSamplerBasic(orNOOPpre-FULU) and passes it to sync; subscribes to slot events; integrates resolver.Written by Cursor Bugbot for commit 3030bfb. This will update automatically on new commits. Configure here.