prevent double callback in case of error #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

mvayngrib wants to merge 1 commit into Consensys:master from mvayngrib:doublecallbackfix

mvayngrib commented Aug 25, 2016

the try/catch shouldn't catch errors in the callback function, otherwise weird side effects arise, e.g. if:

ks.deriveKeyFromPassword('badpassword', function badCallback () {
  throw new Error('misbehavin!') // causes badCallback to get called again
})


          prevent double callback in case of error

a0c64c1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet