Skip to content

Update ComplaintBox.cpp with basic input sanitations #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update ComplaintBox.cpp with basic input sanitations #51

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
69 changes: 69 additions & 0 deletions ComplaintBox.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,75 @@ void ComplaintBox::createTables() {
sqlite3_exec(db, sqlComplaints, 0, 0, &errMsg);
}

bool ComplaintBox::isValidUsername(const string& uname) {
if (uname.length() < 3 || uname.length() > 20) {
cout << BOLDRED << "Username must be between 3 and 20 characters long.\n" << RESET;
return false;
}
for (char c : uname) {
if (!isalnum(c)) {
cout << BOLDRED << "Username can only contain alphanumeric characters.\n" << RESET;
return false;
}
}
return true;
}

bool ComplaintBox::isValidPassword(const string& pass) {
if (pass.length() < 8 || pass.length() > 20) {
cout << BOLDRED << "Password must be between 8 and 20 characters long.\n" << RESET;
return false;
}
bool hasUpperLetter = false, hasLowerLetter = false, hasNumber = false, hasSpecialChar = false;
for (char c : pass) {
if (isupper(c)) hasUpperLetter = true;
if (islower(c)) hasLowerLetter = true;
if (isdigit(c)) hasNumber = true;
if (ispunct(c)) hasSpecialChar = true;
}
if (!(hasUpperLetter && hasLowerLetter && hasNumber && hasSpecialChar)) {
cout << BOLDRED << "Password must contain at least one uppercase letter, one lowercase letter, one number, and one special character.\n" << RESET;
return false;
}
return true;
}

bool ComplaintBox::isValidCategory(const string& input) {
if (input.length() > 50) {
cout << BOLDRED << "Category or subcategory is too long. Maximum length is 50 characters.\n" << RESET;
return false;
}
for (char c : input) {
if (!isalnum(c) && c != ' ') {
cout << BOLDRED << "Category and subcategory can only contain alphanumeric characters and spaces.\n" << RESET;
return false;
}
}
return true;
}

bool ComplaintBox::isValidMessage(const string& message) {
if (message.length() > 500) {
cout << BOLDRED << "Message is too long. Maximum length is 500 characters.\n" << RESET;
return false;
}
string dangerousChars = "'\";-<>/\\";
for (char c : message) {
if (dangerousChars.find(c) != string::npos) {
cout << BOLDRED << "Message contains invalid characters (e.g., single quote, double quote, semicolon).\n" << RESET;
return false;
}
}
return true;
}


void ComplaintBox::registerUser(bool isAdmin) {
string uname, pass;
cout << PURPLE << "Enter username: " << RESET;
cin >> uname;

if (!isValidUsername(uname)) return;

sqlite3_stmt* stmt;
string checkSql = "SELECT 1 FROM users WHERE username = ?";
Expand All @@ -51,6 +116,8 @@ void ComplaintBox::registerUser(bool isAdmin) {

cout << PURPLE << "Enter password: " << RESET;
cin >> pass;

if (!isValidPassword(pass)) return;

string table = isAdmin ? "adminusers" : "users";
string insertSql = "INSERT INTO " + table + " (username, password) VALUES (?, ?);";
Expand Down Expand Up @@ -104,6 +171,8 @@ void ComplaintBox::fileComplaint() {
getline(cin, subCategory);
cout << YELLOW << "Enter complaint message: " << RESET;
getline(cin, message);

if (!isValidCategory(category) || !isValidCategory(subCategory) || !isValidMessage(message)) return;

sqlite3_stmt* stmt;
string sql = "INSERT INTO complaints (category, subCategory, message) VALUES (?, ?, ?);";
Expand Down