Skip to content

Conversation

jabbate19
Copy link
Contributor

image

Idk why I felt the need to do this, but I like colors in CLI

@jabbate19
Copy link
Contributor Author

Oh ffs its stacking over my other branch

Copy link
Member

@Mstrodl Mstrodl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This includes password changes. Cherry-pick your colors commit only.

@jabbate19 jabbate19 requested a review from Mstrodl March 6, 2022 22:30
Copy link
Member

@Mstrodl Mstrodl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to see that version fixed...

@Mstrodl
Copy link
Member

Mstrodl commented Mar 22, 2022

Please rebase this against master, 1 million commits not good

@WillNilges
Copy link
Member

Does this do anything for the ncurses UI?

Copy link
Member

@WillNilges WillNilges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same concern as mary's, plus styling.

@jabbate19 jabbate19 requested a review from WillNilges March 26, 2022 19:38
@jabbate19
Copy link
Contributor Author

For stocked slots, do you two prefer green or white? Here's an example with green

image

@jabbate19 jabbate19 force-pushed the colors branch 2 times, most recently from 486e847 to 5c6a5f1 Compare March 29, 2022 03:17
@WillNilges
Copy link
Member

Green is more fun. Use green!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants