Add Dockerfile #77
Open
Add Dockerfile #77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove install steps from drone.yml Fixes ComputerScienceHouse#76
|
is there a particular reason you chose to use ubuntu as the base image? using alpine or something like that with a smaller footprint might be preferable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a Dockerfile based build-environment container for Bingehack4. I've also made changes to the .drone.yml file to use the most recent image uploaded to Dockerhub (right now this is pointing to an image generated from my fork so that I won't have to change anything in-repo after it's merged in for CI to be happy)
Here's a log of Drone running before the change: https://drone.csh.rit.edu/liam-middlebrook/bingehack4/52/1
And here's a log of Drone running after the change: https://drone.csh.rit.edu/liam-middlebrook/bingehack4/56/1
As you can see there's roughly a 5x speedup for Drone after this change.
Fixes #76