Ci test for picmi pypicongpu #5461

mafshari64 · 2025-08-29T15:45:13Z

All CI tests ran successfully with no failures.

@chillenzer Please review and let me know.

…I tests

ikbuibui · 2025-09-01T09:10:31Z

https://gitlab.com/hzdr/crp/picongpu/-/jobs/11201531056 CI fails in the pypicongpu compile test for LWFA

PrometheusPi

First line already contains a breaking issue - please fix - after that I can continue reviewing

PrometheusPi · 2025-09-01T13:58:33Z

etc/picongpu/bash/bash_picongpu.profile.example

 export PIC_SYSTEM_TEMPLATE_PATH=${PIC_SYSTEM_TEMPLATE_PATH:-"etc/picongpu/bash"}

-export PICSRC=$HOME/src/picongpu
+export PICSRC=/home/afshar87/afshari/simulation/picongpu


This is your specific code

PrometheusPi

For now just a breaking issue:

logs have been uploaded

and a few questions:
Will continue reviewing after fixes and answers have been provided

PrometheusPi · 2025-09-01T14:07:21Z

test/python/picongpu/test.log

This should not be included in a PR.

I will delete it. I think it is created during IC tests.

PrometheusPi · 2025-09-01T14:10:44Z

lib/python/picongpu/picmi/diagnostics/checkpoint.py

    directory: str, optional
-        Directory inside simOutput for writing checkpoints (default: "checkpoints").
-
+        Directory to store checkpoint files. Default: "checkpoints".


Why did you remove the useful information, that these directories are created in the simOutput directory?

PrometheusPi · 2025-09-01T14:11:07Z

lib/python/picongpu/picmi/diagnostics/checkpoint.py

    file: str, optional
-        Relative or absolute fileset prefix for checkpoint files.
-
+        Base name for checkpoint files. Default: None.


Why this renaming?

PrometheusPi · 2025-09-01T14:11:32Z

lib/python/picongpu/picmi/diagnostics/checkpoint.py

    tryRestart: bool, optional
-        If True, restart from the latest checkpoint if available, else start from scratch.
-
+        Attempt to restart from existing checkpoints. Default: None.


Why this in my opinion less clear description?

PrometheusPi · 2025-09-01T14:12:06Z

lib/python/picongpu/picmi/diagnostics/checkpoint.py

    restartDirectory: str, optional
-        Directory inside simOutput containing checkpoints for restart (default: "checkpoints").
-
+        Directory to look for restart files. Default: None.


why remove the reference to this directory being inside simOutput?

BrianMarre · 2025-09-01T14:18:56Z

test/python/picongpu/quick/pypicongpu/output/timestepspec.py

This looks like a reversion, unless you are actively changing something in this file please remove these changes.

BrianMarre · 2025-09-01T14:20:52Z

test/python/picongpu/test.log

This file should not be part of the PR

I deleted test.log files and used the old definitions, which were clearer. I will wait for further comments and then push a new commit tomorrow.

chillenzer · 2025-09-02T09:09:16Z

test/python/picongpu/quick/pypicongpu/output/timestepspec.py

Why is this file touched at all, let alone what the actual changes are supposed to do?

chillenzer · 2025-09-03T10:55:38Z

Offline discussion: This PR will be split into one PR adding tests to PICMI/PyPIConGPU plugin implementations and one PR introducing the openPMD plugin. Further improvements are

OpenPMD plugin

Massively reduce code duplication in the openPMD sources, potentially via a default implementation in the base class.
Potentially wait for Refactor passing parameters from PICMI to PyPIConGPU #5456 and use a variant of converts_to

Tests

Avoid testing already-tested functionality through different interfaces (like TimeStepSpec behaviour from within the plugin tests)
Introduce some infrastructure to unify and simplify the tests

Afterwards, we'll hopefully see more clearly and can actually start reviewing this contribution.

PrometheusPi · 2025-09-22T07:36:05Z

@mafshari64 Your code has merge-conflicts. Please resolve.

PrometheusPi · 2025-09-23T11:53:05Z

@mafshari64 The content of your last commit 51a0708 regarding the laser base definition is good but should not be added in a hidden way as part of your commit.
Please open it as a separate pull request.

mafshari64 · 2025-09-23T11:57:53Z

@mafshari64 The content of your last commit 51a0708 regarding the laser base definition is good but should not be added in a hidden way as part of your commit. Please open it as a separate pull request.

@PrometheusPi I plan to do it.

mafshari64 added 30 commits August 29, 2025 17:29

adding openpmd.py and charge_density.py

809dde8

common interface for all the current sources of the openPMD plugin

43d75d9

adding species to openpmd sources

c25e8cb

adding other openpmd picongpu sources

d29e104

providing openpmd sources for pypicongpu

7557c96

adding schema for openpmd plugin

d3d0d40

updating openpmd files

0320db9

finalizing openpmd plugin

0515b28

adding rangespec class to openpmd

d69e0d5

editing pypicongpu/output/openpmd.py

95cfb14

removing Default simulation_box to fix CI LWFA

8f3052a

add simulation_box to s.plugin in picmi.simulation.py

2ddd015

Fix TypeError in PhaseSpace and Auto by adding simulation_box parameter

8925047

Fix TypeError for openpmd plugin

9cd6366

Fix simulation_box usage in simulation.py to resolve ruff F841 error

759b589

Add EnergyHistogram test suite and CI pipeline

98a099c

Add pypicongpu/output/macro_particle_count.py test

768076e

Add checkpoint CI test

36a75dc

Add png CI test

6152432

Add openpmd CI test

df01c14

Add rangespec CI test

50036b5

removing bugs for energy_histogram and checkpoint CI test

be37b06

removing bugs for macro_particle_count and png CI tests

12498ad

removing bugs for png and rangespec CI tests

4009cb2

removing bugs for openpmd CI test

3d6ea49

added openpmd_sources subclasses CI test

73dc051

added rangespec and auto PICMI CI test

96d04f5

added rangespec and energy_histogram and macro_particle_count PICMI C…

be97bd5

…I tests

updating PICMI CI tests by adding int´to period alongwith timestepspec

cc9180c

debugging PICMI CI timestepspec and auto

d461cf1

mafshari64 added 5 commits August 29, 2025 17:38

debugging PICMI CI openpmd

b89c965

debugging PICMI CI openpmd 1

67b132b

debugging PICMI CI openpmd 1

b68451b

all CI tests ran successfullly with no failures

44c97e5

all CI tests ran successfullly with no failures 1

d816894

mafshari64 force-pushed the CI_test_picmi_pypicongpu branch from e8148c1 to d816894 Compare August 29, 2025 16:03

correcting folder_name to folder to match png plugin

e374ef3

ikbuibui added the PICMI pypicongpu and picmi related label Sep 1, 2025

mafshari64 added 2 commits September 1, 2025 11:35

add more axis to png axis

aff59ed

fix main.py LWFA example

357d64b

PrometheusPi requested changes Sep 1, 2025

View reviewed changes

fix HOME/src/picongpu issue

4a7818b

PrometheusPi requested changes Sep 1, 2025

View reviewed changes

BrianMarre reviewed Sep 1, 2025

View reviewed changes

delete test.log and checkpoint docstring

92ae438

chillenzer requested changes Sep 2, 2025

View reviewed changes

chillenzer mentioned this pull request Sep 2, 2025

openpmd.py plugin for PICMI #5353

Closed

chillenzer marked this pull request as draft September 4, 2025 07:24

mafshari64 added 5 commits September 5, 2025 18:39

modifying pypicongpu CI test

694e16b

repacking multi sources to a single source file

5a2332e

classifying all openpmd sources CI test

bc39fa8

finalizing PICMI - pypicongpu CI tests

d8de6b5

fixing some conflicts

80c57ab

fixing a0 E0 condition for base_laser

51a0708

Ci test for picmi pypicongpu #5461

Are you sure you want to change the base?

Ci test for picmi pypicongpu #5461

Uh oh!

Conversation

mafshari64 commented Aug 29, 2025

Uh oh!

ikbuibui commented Sep 1, 2025

Uh oh!

PrometheusPi left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

PrometheusPi left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mafshari64 Sep 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chillenzer commented Sep 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

PrometheusPi commented Sep 22, 2025

Uh oh!

PrometheusPi commented Sep 23, 2025

Uh oh!

mafshari64 commented Sep 23, 2025

Uh oh!

Uh oh!

PrometheusPi left a comment •

edited

Loading

PrometheusPi left a comment •

edited

Loading

mafshari64 Sep 1, 2025 •

edited

Loading

chillenzer commented Sep 3, 2025 •

edited

Loading