Improve pmacc dataspace #5416
Draft
Improve pmacc dataspace #5416
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikbuibui
force-pushed
the
dataSpace
branch
2 times, most recently
from
57e2b0e to
0377312
Compare
|
Currently this causes a segfault inside the compiler with gcc11 and cuda 12.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses
index_sequencebased parameter pack expansions instead of for loops inDataSpace. Im not sure about this change, because although it helps prevent first constructing and then assigning in many cases, it is harder to read. Also most likely the compiler is quite smart and sees through the for loops, but I haven't looked into the assembly to compare.Also removes user defined defaulted copy constructor for
SelectionandDataSpace, as this causes clang to throw a warning