Skip to content

Adding Docker support #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Adding Docker support #18

wants to merge 2 commits into from

Conversation

sopitz
Copy link

@sopitz sopitz commented Oct 6, 2016

I wanted to try out Communote but didn't feel like installing it on my machine directly. I quickly added some docker support. Is that worth keeping for you? Then I would beautify it a bit.

Feedback very welcome!

@rwi
Copy link
Member

rwi commented Oct 10, 2016

@sopitz this is a great idea and it's definitely worth keeping 👍

When beautifying it could you please also have a look at the following things:

Since the tomcat Docker image is based on an Open JDK Java image we should probably also have a hint in the README explaining that it is beta/not meant for production use because we officially only support Oracle's JRE and haven't tested with Open JDK.

@sopitz
Copy link
Author

sopitz commented Oct 10, 2016

ok. I'll refactor it and update the pull request then.

the add will surely be replaced, and I'll also try'n use a non-tomcat-base image, it was just to put it together initially (it had everything installed already :D)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants