Tracking: Manage changes dialog alignments #13271
Open
+83
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
banobepascal
force-pushed
the
private/banobepascal/manage-changes
branch
4 times, most recently
from
a055206 to
92af29e
Compare
|
can we have visual test with some complex content ? |
eszkadev
reviewed
Oct 23, 2025
-Fixed misalignment between ui-treeview-headers and ui-treeview-entries by setting consistent grid-template-columns -Apply progressive left padding using ch units to .ui-treeview-expander-column and .ui-treeview-icon-column based on aria-level for a consistent treeview Signed-off-by: Banobe Pascal <[email protected]> Change-Id: I2f01913f09f19485c3cab703b7a5d16ebcdd70e8
banobepascal
force-pushed
the
private/banobepascal/manage-changes
branch
from
92af29e to
bcd9d2f
Compare
eszkadev
previously requested changes
Oct 24, 2025
github-project-automation
bot
moved this from To Review
to In Progress
in Collabora Online
- Add visual regression test for the manage changes dialog treeview - Opens the dialog from the Review tab in notebookbar - Expands all tree view entries to show the complete change history - Captures a snapshot to detect visual regressions Signed-off-by: Banobe Pascal <[email protected]> Change-Id: Iff75345375e392ef9b6ea37aeb35ed9797233ed4
eszkadev
reviewed
Oct 27, 2025
| } | ||
|
|
||
| #AcceptRejectChangesDialog .ui-treeview-headers { | ||
| grid-template-columns: 120px 120px 150px 130px; |
There was a problem hiding this comment.
isn't that a bit like "we delay the problem"? so when long enought comment appears in the table it will again cover some other column? :)
There was a problem hiding this comment.
Comments don't appear in the table as comments rather we add a label "Comment Deleted" or "Added"
eszkadev
reviewed
Oct 27, 2025
cypress_test/integration_tests/desktop/writer/manage_changes_dialog_spec.js
Show resolved
Hide resolved
pedropintosilva
approved these changes
Oct 27, 2025
github-project-automation
bot
moved this from In Progress
to To Test
in Collabora Online
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: I159dc6b28c5837bcc7820389546bd04ec532d768
Summary
-Fixed misalignment between ui-treeview-headers and ui-treeview-entries by setting consistent grid-template-columns
-Apply progressive left padding using ch units to .ui-treeview-expander-column and .ui-treeview-icon-column based on aria-level for a consistent treeview
PREVIEW
Checklist
make prettier-writeand formatted the code.make checkmake runand manually verified that everything looks okay