Skip to content
This repository was archived by the owner on Feb 6, 2021. It is now read-only.

Conversation

Rohith04MVK
Copy link

No description provided.

@Rohith04MVK Rohith04MVK requested a review from a team July 18, 2020 10:01
Comment on lines +43 to +44
async def flip_coin():
def coin_filp():
Copy link
Contributor

@ItsDrike ItsDrike Jul 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We require all functions to have proper docstrings as these are what will be displayed in the >>help even though this command is pretty self-descriptive, it should still have a docstring, same goes for dice command

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, @ItsDrike we shouldn't worry about the >>help command since it will be replaced by the paginator once it is released.

Copy link
Contributor

@ItsDrike ItsDrike Jul 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@e-xe even with it replaced docstrings will still be used as a command descriptions even with it being paginated

return "Tails"

await ctx.send(coin_filp())
from random import randint
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All import should be on top and properly sorted (accordingly to flake8)

@ItsDrike ItsDrike added priority: 3 - low Low priority status: waiting for author Waiting for author to address a review or respond to a comment type: feature New feature or request labels Jul 18, 2020
embed.add_field(name="Answer", value=answer)

await ctx.send(embed=embed)
@command()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need to configure an alias for faster usage, instead of keeping just this long name

Suggested change
@command()
@command(aliases=["cflip"])

Comment on lines +55 to +57
async def dice():
dice_roll = randint(1,6)
await ctx.send(dice_roll)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Give a default values for the range, and customizable range

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

priority: 3 - low Low priority status: waiting for author Waiting for author to address a review or respond to a comment type: feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants