-
Notifications
You must be signed in to change notification settings - Fork 14
Added Dice and Coin flip #87
base: master
Are you sure you want to change the base?
Conversation
async def flip_coin(): | ||
def coin_filp(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We require all functions to have proper docstrings as these are what will be displayed in the >>help
even though this command is pretty self-descriptive, it should still have a docstring, same goes for dice
command
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, @ItsDrike we shouldn't worry about the >>help
command since it will be replaced by the paginator once it is released.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@e-xe even with it replaced docstrings will still be used as a command descriptions even with it being paginated
return "Tails" | ||
|
||
await ctx.send(coin_filp()) | ||
from random import randint |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All import should be on top and properly sorted (accordingly to flake8)
embed.add_field(name="Answer", value=answer) | ||
|
||
await ctx.send(embed=embed) | ||
@command() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you need to configure an alias for faster usage, instead of keeping just this long name
@command() | |
@command(aliases=["cflip"]) |
async def dice(): | ||
dice_roll = randint(1,6) | ||
await ctx.send(dice_roll) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Give a default values for the range, and customizable range
No description provided.