-
Notifications
You must be signed in to change notification settings - Fork 14
Fixed converter command #46
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to pass all of Travis-CI checks before merging, if you don't know what's wrong, you can click details link next to the check which will point you to the specific check where you can see what's wrong, in this case the url for that is: this
I've pointed out multiple of these errors in my requested changes too, since they have to do with unnecessary line splitting. You should also use pre-commit so that you can run these checks locally before pushing here, for more info about that you should read through our CONTRIBUTING.md
pre-commit
is described in third rule there.
embed = Embed( | ||
title="Info", description=f":ping_pong: Pong! ({duration}ms)", color=Color.blurple(),) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
embed = Embed( | |
title="Info", description=f":ping_pong: Pong! ({duration}ms)", color=Color.blurple(),) | |
embed = Embed(title="Info", description=f":ping_pong: Pong! ({duration}ms)", color=Color.blurple()) |
Our line limit is 150, which this line is well within, there is no reason to split it.
Same thing applies to lines: 44-45, 75-76, 89-90
client = commands.Bot(commands.when_mentioned_or( | ||
PREFIX), case_insensitivity=True, owner_id=688275913535914014) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
client = commands.Bot(commands.when_mentioned_or( | |
PREFIX), case_insensitivity=True, owner_id=688275913535914014) | |
client = commands.Bot(commands.when_mentioned_or(PREFIX), case_insensitivity=True, owner_id=688275913535914014) |
Our line limit is 150, which this line is well within, there is no reason to split it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I literally have no idea why that has happened.
SUPPORT_SERVER = "https://discord.gg/CgH6Sj6" | ||
INVITE = "https://discord.com/api/oauth2/authorize?client_id=715545167649570977&permissions=980675863&scope=bot" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These things are defined in constants.py
it would be wiser to use that instead of re-defining them here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't actually made that change. No idea why it shows up.
Fixed undefined algo (wrong variable used). Converter command is now fully operational with hashlib algorithms.