Add default font customization flags for FunkinText #762
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds two new flags, that being
DEFAULT_FONTandDEFAULT_FONT_SIZE.DEFAULT_FONTreplaces the prior use ofvcr.tffwhen loading the font inFunkinTextbut defaults tovcr.tff, while the size parameter in FunkinText's constructor has been changed to be purely optional without a default value, where having that parameter be null makes it so that it fetchesDEFAULT_FONT_SIZEby default.These changes intend to simplify the usage of custom fonts, especially in regards to
PlayState.