-
-
Notifications
You must be signed in to change notification settings - Fork 271
Fixed / Refactored SysZip to actually work, and store compressed entries without uncompressing an entire zip #761
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There is an issue with streamed audio it seems like |
Seems the streamed audio bug was fixed, though now I found an issue with videos not loading properly so debugging that |
stupid fuckin hxvlc and VideoCutscene implementation |
there is still an issue with how videos are loaded so need to find a way to fix it... |
just fixed it by implementing what VideoCutscene did because it actually works amazing lmao |
…'s fix for ZIP videos, and also removed that fix in favor for just fixing the issue entirely
After some testing it seems all the issues have been fixed. The only issue that can occur is if the Mod owner doesn't change their |
ok adding a feature in rq that pre-caches each video in the mod because unzipping loading time takes a hot sec, and videos easily get desynced |
…Library. Since videos have to be decompressed and be saved as a file anyways this reduces the time to do that, and what not.
Alr makred as ready now !! unless I find another bug again lmao |
…ist to be passed as a `.zip`
ughghghghghghhhhhh unready now, someone test zip mods with addons, and the new Flag I added to support custom zip extensions |
from my quick testing it seems like it works |
…h .cnemod with a .zip inside LMAO)
…abilites to detect if a library is considered compressed
Ok this branch is ready to merge. The Streamed Audio bug just seems to be a mod specific issue, and happens rarely often on that mod. |
Refactored
SysZip
so that now it properly reads eachEntry
and saves only required information to unzip anyEntry
in the zip.It no longer extends
Reader
since it's a custom implementation of unzipping by yours truely.This commit also added a
CoolUtil
function for using thehaxe.Timer.stamp()
function to quickly see how long it takes for code to run.Calling it once will start the timer, and call it again to finish the debug output. It also does fancy tracing. 👀