Skip to content

Conversation

ItsLJcool
Copy link
Contributor

Refactored SysZip so that now it properly reads each Entry and saves only required information to unzip any Entry in the zip.
It no longer extends Reader since it's a custom implementation of unzipping by yours truely.

This commit also added a CoolUtil function for using the haxe.Timer.stamp() function to quickly see how long it takes for code to run.
Calling it once will start the timer, and call it again to finish the debug output. It also does fancy tracing. 👀

@ItsLJcool
Copy link
Contributor Author

There is an issue with streamed audio it seems like

@FuroYT FuroYT added the status:accepted This has been solved successfully label Sep 4, 2025
@ItsLJcool
Copy link
Contributor Author

Seems the streamed audio bug was fixed, though now I found an issue with videos not loading properly so debugging that

@ItsLJcool
Copy link
Contributor Author

stupid fuckin hxvlc and VideoCutscene implementation

@ItsLJcool
Copy link
Contributor Author

there is still an issue with how videos are loaded so need to find a way to fix it...

@ItsLJcool
Copy link
Contributor Author

just fixed it by implementing what VideoCutscene did because it actually works amazing lmao

@ItsLJcool
Copy link
Contributor Author

After some testing it seems all the issues have been fixed.

The only issue that can occur is if the Mod owner doesn't change their Flags.VIDEO_EXT when trying to load other video extensions, causing it to not be detected in ZipFolderLibrary but easy to figure out probably?

@ItsLJcool
Copy link
Contributor Author

ok adding a feature in rq that pre-caches each video in the mod because unzipping loading time takes a hot sec, and videos easily get desynced

…Library.

Since videos have to be decompressed and be saved as a file anyways this reduces the time to do that, and what not.
@ItsLJcool
Copy link
Contributor Author

Alr makred as ready now !!

unless I find another bug again lmao

@ItsLJcool
Copy link
Contributor Author

ughghghghghghhhhhh unready now, someone test zip mods with addons, and the new Flag I added to support custom zip extensions

@ItsLJcool
Copy link
Contributor Author

from my quick testing it seems like it works

@ItsLJcool
Copy link
Contributor Author

Ok this branch is ready to merge. The Streamed Audio bug just seems to be a mod specific issue, and happens rarely often on that mod.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:accepted This has been solved successfully
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants