ci: convert production workflows #3192
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View your CI Pipeline Execution ↗ for commit e8d3517 ☁️ Nx Cloud last updated this comment at |
dreamwasp
commented
Oct 23, 2025
Comment on lines
-23
to
-31
| - name: Wait for CI build | ||
| uses: fountainhead/[email protected] | ||
| id: wait-for-build | ||
| with: | ||
| token: ${{ secrets.ACTIONS_GITHUB_TOKEN }} | ||
| checkName: build-test | ||
| ref: ${{ github.event.pull_request.head.sha || github.sha }} | ||
| timeoutSeconds: 1200 | ||
| intervalSeconds: 30 |
There was a problem hiding this comment.
changed the required checks to the following, so shouldn't need this anymore
dreamwasp
commented
Oct 23, 2025
| @@ -0,0 +1,156 @@ | |||
| # CircleCI to GitHub Actions Migration Summary | |||
There was a problem hiding this comment.
will remove before shiupping, but wanted to keep cursors notes for the review
dreamwasp
changed the title
|
📬 Published Alpha Packages: |
|
🚀 Styleguide deploy preview ready! Preview URL: https://68fa583656780d46418782ed--gamut-preview.netlify.app |
jakemhiller
reviewed
Oct 23, 2025
| - main | ||
|
|
||
| env: | ||
| NODE_VERSION: '22.13.1' |
There was a problem hiding this comment.
minor but i don't think this is used, we use the version from .nvmrc when we run actions/setup-node
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Converts the production workflows from CircleCI to GHA including cacheing. Also configures required checks from CircleCI to Github settings
PR Checklist
Testing Instructions
I don't really know how to test this. I can make the test below fail to show you the required tests are failing but I do think this is a yolo situation.
I will merge this despite the CircleCi Pipeline failure, I'll disable the pipeline after this is shipped.
PR Links and Envs
N/A