Skip to content

Conversation

Mahtem
Copy link

@Mahtem Mahtem commented Oct 17, 2025

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

I have addressed all the cases in all 12 .js files. Described what lines of code do, reported and corrected errors, and
made necessary changes according to the questions and guidelines in the files.

Questions

So far I have no question

@Mahtem Mahtem added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Oct 17, 2025
Copy link

@CameronDowner CameronDowner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good 🙂 I've left a couple questions and comments

// This should produce the string "CKJ", but you must not write the characters C, K, or J in the code of your solution.

let initials = ``;
let initials = firstName[0]+middleName[0]+lastName[0];

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this be done using a template string?

// Step-4 ---> the resukt of Step-3 is round by the method Math.floor
// Step-5 ---> minimum is added to the result of Step-4

// Thus, num represents random numbers generated between minimum 1 and maximum 100. As we run the code several times it

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thus, suggests to me this might've been generated by AI

Remember, the aim of this is to ensure you're understanding the exercises. It's hard to do this if you don't write the answers in your own words

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've decided Thus is not a good indicator of AI 👀

const age = 33;
//const age = 33;

// we need to replace "const" with "let"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the difference between const and let?

// c) Using documentation, explain what the expression movieLength % 60 represents
// https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Arithmetic_Operators

// Ans: The expression movieLength % 60 returns the reminder after totalMinutes is divided by 60.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is correct - just slight typo: reminder should be remainder


// e) What do you think the variable result represents? Can you think of a better name for this variable?

// Ans: the variable result represent total movie lenght, Movie duration_hr_min_sec would be better name.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In Javascript, the convention is to use "camel case". This would be perfect for a language like Python 🙂

Could you suggest one in camel case?

See this article: link

@CameronDowner CameronDowner added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 18, 2025
Comment on lines 36 to 38
// 1. MovieDurationHrMinSec
// 2. TotalMovieSpan
// 3. TotalMoviePeriod

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is what we call PascalCase (the first letter is capatalised) which is not quite right for this

  • camelCase
  • PascalCase
  • snake_case
  • kebab-case

Each language will have a convention of using a certain case - for Javascript it's camelCase

@Mahtem Mahtem added the 📅 Sprint 1 Assigned during Sprint 1 of this module label Oct 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Reviewed Volunteer to add when completing a review with trainee action still to take. 📅 Sprint 1 Assigned during Sprint 1 of this module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants