West Midlands | ITP-Sep-2025 | Ahmad Ehsas | Sprint 2 | Structuring and Testing Data #734

ahmadehsas · 2025-10-05T21:34:06Z

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

I have completed all the mandatory coursework. which includes:

key exercises.
key errors.
mandatory debug.
mandatory implement.
mandatory interpret.

Questions

Ask any questions you have for your reviewer.

…e error. and finally, rewrote the code to fix the problem.

…n incorrectly. i explained the error and rewrote the code as a comment.

…ssue and fixed the code.

…hen explained it in comment how to calculate the BMI.

…on many times for different inputs.

…hese questions.

github-actions · 2025-10-05T21:34:22Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-10-05T21:34:23Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-10-05T21:34:25Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-10-05T21:34:30Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-10-05T21:34:38Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-10-05T21:34:38Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-10-09T17:27:23Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-10-09T17:27:26Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

tenzyns · 2025-10-09T18:50:03Z

Sprint-2/1-key-errors/1.js

  return percentage;
 }

 console.log(decimalNumber);


Do you think console.log() is calling an undeclared variable decimalNumber instead of the function convertToPercentage(0.5)? You have corrected the function on line 25.

tenzyns · 2025-10-09T19:06:20Z

Sprint-2/2-mandatory-debug/1.js

 console.log(`The sum of 10 and 32 is ${sum(10, 32)}`);

-// =============> write your explanation here
+// =============> write your explanation here: in the code above, the function Sum is not returning because the return function is not defined and it is written incorrectly. The return function should be written before the a + b values.//


We could say the statement a+b is unreachable because there is an empty return statement before it.
You have fixed the code correctly.

tenzyns · 2025-10-09T20:32:16Z

Sprint-2/4-mandatory-interpret/time-format.js


 // a) When formatTimeDisplay is called how many times will pad be called?
-// =============> write your answer here
+// =============> write your answer here: When formatTimeDisplay is called four times pad will be called, one for remainingSeconds, one for remainingMinutes, one for totalMinutes and one for totalHours.


The function pad(num) is called inside the formatTimeDisplay function. And if we look inside, how many times do we see the function name pad? we do see there are 3 different arguments being called by each.

tenzyns · 2025-10-09T20:35:44Z

Sprint-2/4-mandatory-interpret/time-format.js


 // b) What is the value assigned to num when pad is called for the first time?
-// =============> write your answer here
+// =============> write your answer here: When pad is called for thee first time, num will be assigned the value of 1, which is the value of remainingSeconds.


can you spot where the function pad is called first? which argument does it have?

tenzyns · 2025-10-09T20:57:09Z

Sprint-2/4-mandatory-interpret/time-format.js


 // c) What is the return value of pad is called for the first time?
-// =============> write your answer here
+// =============> write your answer here: The return value of pad when called for the first time will be `01` because it pads the number 1 with a leading zero to make it two digits.


when you find out when the function pad is called first from above, we can figure out return value here.

tenzyns · 2025-10-09T21:00:00Z

Sprint-2/4-mandatory-interpret/time-format.js


 // d) What is the value assigned to num when pad is called for the last time in this program?  Explain your answer
-// =============> write your answer here
+// =============> write your answer here: When pad is called for the last time, num will be assigned the value of 0, which is the value of totalHours.


Like above, we can find out when a function is called first based on the order in which it is called in the series. In other words, which appears first in the series.

tenzyns · 2025-10-09T21:01:16Z

Sprint-2/4-mandatory-interpret/time-format.js


 // e) What is the return value assigned to num when pad is called for the last time in this program?  Explain your answer
-// =============> write your answer here
+// =============> write your answer here: when pad is called for the last time, the return value will be `0` because it pads the number 0 with a leading zero to make it two digits.


This will also change when we know the above.

github-actions · 2025-10-09T21:02:01Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-10-09T21:02:04Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-10-10T19:21:29Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-10-10T19:21:33Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

ahmadehsas added 10 commits June 16, 2025 17:22

Answered comment for count update in exercise -1

65fe894

predicted and explained the error. and finally, fixed the code.

c2e158f

the error is predicted before running the code and then explained th…

5e632d2

…e error. and finally, rewrote the code to fix the problem.

explained the technical error and fixed the code as comment.

4cdfdd4

The sum function is undefined because the function return was writte…

eb5e0dc

…n incorrectly. i explained the error and rewrote the code as a comment.

in this code the function is not working properly. I explained the i…

a696e17

…ssue and fixed the code.

i returned the Body Mass Index(BMI) of myselfin return function and t…

84ed53e

…hen explained it in comment how to calculate the BMI.

i turned the code into reusable block of code and i called the functi…

7a09127

…on many times for different inputs.

I answered all the questions and python visualiser helped me answer t…

f813ae6

…hese questions.

Implemented the function called toUpperSnakeCase.

6e2a97e

ahmadehsas added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Oct 5, 2025

tenzyns added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 9, 2025

tenzyns reviewed Oct 9, 2025

View reviewed changes

tenzyns added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Oct 9, 2025

tenzyns added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Complete Volunteer to add when work is complete and all review comments have been addressed. labels Oct 10, 2025

Uh oh!

West Midlands | ITP-Sep-2025 | Ahmad Ehsas | Sprint 2 | Structuring and Testing Data #734

Are you sure you want to change the base?

West Midlands | ITP-Sep-2025 | Ahmad Ehsas | Sprint 2 | Structuring and Testing Data #734

Uh oh!

Conversation

ahmadehsas commented Oct 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changelist

Questions

Uh oh!

github-actions bot commented Oct 5, 2025

Uh oh!

github-actions bot commented Oct 5, 2025

Uh oh!

github-actions bot commented Oct 5, 2025

Uh oh!

github-actions bot commented Oct 5, 2025

Uh oh!

github-actions bot commented Oct 5, 2025

Uh oh!

github-actions bot commented Oct 5, 2025

Uh oh!

github-actions bot commented Oct 9, 2025

Uh oh!

github-actions bot commented Oct 9, 2025

Uh oh!

tenzyns Oct 9, 2025

Choose a reason for hiding this comment

Uh oh!

tenzyns Oct 9, 2025

Choose a reason for hiding this comment

Uh oh!

tenzyns Oct 9, 2025

Choose a reason for hiding this comment

Uh oh!

tenzyns Oct 9, 2025

Choose a reason for hiding this comment

Uh oh!

tenzyns Oct 9, 2025

Choose a reason for hiding this comment

Uh oh!

tenzyns Oct 9, 2025

Choose a reason for hiding this comment

Uh oh!

tenzyns Oct 9, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Oct 9, 2025

Uh oh!

github-actions bot commented Oct 9, 2025

Uh oh!

github-actions bot commented Oct 10, 2025

Uh oh!

github-actions bot commented Oct 10, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ahmadehsas commented Oct 5, 2025 •

edited

Loading