-
-
Notifications
You must be signed in to change notification settings - Fork 221
NW | 25-ITP-Sep | TzeMing Ho | Sprint 3 | coursework/sprint-3-stretch #714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 9 commits
9d43b8b
b0265ba
f1ac2fe
78b6e92
1b11c5a
596bf65
bfae2f8
4eb2d5b
9c8e884
f0d7b15
d5d16fa
5a7757f
9447d08
791b52a
70f9400
c1efb3f
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
function creditCardValidator(cardNumber) { | ||
// Remove all - and spaces from the input | ||
const sanitized = cardNumber.replace(/[-\s]/g, ""); | ||
|
||
//check if the length of the sanitized input is 16 | ||
if (sanitized.length !== 16) { | ||
return false; | ||
} | ||
// check if the sanitized input contains only digits | ||
if (!/^\d{16}$/.test(sanitized)) { | ||
return false; | ||
} | ||
|
||
// check if there ara at least two different digits | ||
const uniqueDigits = new Set(sanitized); | ||
if (uniqueDigits.size < 2) { | ||
return false; | ||
} | ||
|
||
// check if the last digit is even | ||
const lastDigit = Number(sanitized[sanitized.length - 1]); | ||
if (lastDigit % 2 !== 0) { | ||
return false; | ||
} | ||
|
||
// check if the sum of all digits is greater than 16 | ||
const sum = sanitized | ||
.split("") | ||
.reduce((total, digit) => total + Number(digit), 0); | ||
if (sum <= 16) { | ||
return false; | ||
} | ||
|
||
return true; | ||
} | ||
|
||
module.exports = creditCardValidator; |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
const creditCardValidator = require("./creditCard-validator"); | ||
|
||
describe("creditCardValidator", () => { | ||
test("should return true for a 16 digit long card number", () => { | ||
expect(creditCardValidator("1234-5678-9012-3456")).toBe(true); | ||
expect(creditCardValidator("1234 5678 9012 3456")).toBe(true); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Your tests all currently assume there are extra characters in the credit card number - is There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You are right. I should have included tests for card numbers that are more or fewer than 16 digits. As you suggested, I created one test for the case of fewer and another for more. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. These extra tests look good, but aren't quite getting at the problem I was pointing at - can you add a test for a 16-digit credit card number which is only numbers (i.e. no spaces or There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yeah. I included a test for only 16 digits without spaces or operators. |
||
}); | ||
|
||
test("should return false if the card number is not digit only", () => { | ||
expect(creditCardValidator("1234-5678-9012-345a")).toBe(false); | ||
illicitonion marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
expect(creditCardValidator("1234 5678 9012 3456")).toBe(true); | ||
}); | ||
|
||
test("should return false if the card number does not contain at least two different digits", () => { | ||
expect(creditCardValidator("1111-1111-1111-1111")).toBe(false); | ||
expect(creditCardValidator("1111 2222 2222 2222")).toBe(true); | ||
}); | ||
|
||
test("should return false if the card number does not end with an even digit", () => { | ||
expect(creditCardValidator("1234-5678-9012-3457")).toBe(false); | ||
expect(creditCardValidator("1234 5678 9012 3456")).toBe(true); | ||
}); | ||
|
||
test("should return false if the sum of all the digits is not greater than 16", () => { | ||
expect(creditCardValidator("0000-0000-0000-0000")).toBe(false); | ||
expect(creditCardValidator("1111 1111 1111 1111")).toBe(false); | ||
expect(creditCardValidator("1234 5678 9012 3456")).toBe(true); | ||
}); | ||
}); |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,41 @@ | ||
function passwordValidator(password) { | ||
return password.length < 5 ? false : true | ||
} | ||
const lengthCondition = password.length >= 5; | ||
console.log(`length condition: ${lengthCondition}`); | ||
|
||
const uppercaseCondition = /[A-Z]/.test(password); | ||
console.log(`upper case condition: ${uppercaseCondition}`); | ||
|
||
const lowercaseCondition = /[a-z]/.test(password); | ||
console.log(`lower case condition: ${lowercaseCondition}`); | ||
|
||
const numberCondition = /[0-9]/.test(password); | ||
console.log(`number condition: ${numberCondition}`); | ||
|
||
const symbolCondition = /[!#$%.*&]/.test(password); | ||
console.log(`symbol condition: ${symbolCondition}`); | ||
|
||
const previousPasswords = [ | ||
|
||
"123Ab!", | ||
"abcD1#", | ||
"Password1!", | ||
"Qwerty1*", | ||
"Zxcvbnm2$", | ||
]; | ||
const notInPreviousPasswords = !previousPasswords.includes(password); | ||
console.log(`previous password condition: ${notInPreviousPasswords}`); | ||
|
||
if ( | ||
lengthCondition && | ||
uppercaseCondition && | ||
lowercaseCondition && | ||
numberCondition && | ||
symbolCondition && | ||
notInPreviousPasswords | ||
) { | ||
return true; | ||
} else { | ||
return false; | ||
} | ||
illicitonion marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
} | ||
|
||
module.exports = passwordValidator; | ||
module.exports = passwordValidator; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By putting a
{16}
here, you're checking the length again. This means we're checking the length twice.This is fine, but if we wanted to change the expected length of a credit card, we'd need to change both.
Can you think how to avoid this duplication?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Daniel,
Thank you for pointing out that I have repeated the code. Regarding the issue, I have added a variable to store the value 16, and learned that if I want to apply the variable in a pattern, I need to call a new Regex function with the variable. It is something new and useful for me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works! There are a couple of other ways I could imagine going about this - can you think what they may be? (Happy to just discuss them in this comment thread, you don't need to change the code any more :))
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess I understood what you meant by 'other ways.' Since we only have to check the length of 16 for once, the function will fail at the first condition check if the card number is not 16. I don't have to do it again in the second condition check. I could have focused on the characters that are all digits like /^\d+$/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exactly :) Alternatively you could keep the
{16}
in the regex and delete the first length check completely (because any non-16-character string would fail the regex check).